Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR:12393] Adding ipv6_mgmt_only test case into PR testing and fix fixture errors #12805

Merged
merged 1 commit into from
May 13, 2024

Conversation

sdszhang
Copy link
Contributor

original PR (#12393). cherry-pick to 202305

Summary:

  1. Add ip/test_mgmt_ipv6_only.py into PR pipeline testing.
  2. Rearrange fixture order for two test cases: ip/test_mgmt_ipv6_only.py::test_rw_user_ipv6_only and ip/test_mgmt_ipv6_only.py::test_ro_user_ipv6_only.
  3. Workaround pytest fixture teardown bug affecting setup_ntp when run the ip/test_mgmt_ipv6_only.py tests.

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

sonic-net#12393)

Summary:
1. Add `ip/test_mgmt_ipv6_only.py` into PR pipeline testing.
2. Rearrange fixture order for two test cases: `ip/test_mgmt_ipv6_only.py::test_rw_user_ipv6_only` and `ip/test_mgmt_ipv6_only.py::test_ro_user_ipv6_only`.
3. Workaround pytest fixture teardown bug affecting `setup_ntp` when run the `ip/test_mgmt_ipv6_only.py` tests.
@sdszhang sdszhang requested review from yejianquan and qiluo-msft May 10, 2024 12:39
Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 39e5aed into sonic-net:202305 May 13, 2024
12 checks passed
@sdszhang sdszhang deleted the cherry/202305/12393 branch May 13, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants