Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sflow]: backport psample and act_sample drivers, needed for sonic-vs platform #94

Merged
merged 1 commit into from
Aug 10, 2019

Conversation

rakeshdatta
Copy link
Contributor

@rakeshdatta rakeshdatta commented Jul 31, 2019

  • What I did

Backport psample and act_sample drivers to sonic linux kernel 4.9.

  • How I did it

Both psample and act_sample are needed for sflow feature.

psample driver is needed for collecting samples from the interfaces at the kernel level.
act_sample driver is needed for the 'tc' command to be able to program the sampling configurations into the interfaces at the kernel level.

psample and act_sample drivers are not back-ported yet to the linux kernel version that sonic-linux-kernel is using. Hence, I have taken the patches for both the drivers and included it in our sonic kernel.

  • How to verify it

    • Using Build infrastructure changes to support sflow docker and utilities sonic-buildimage#3251 changes, build a sonic image
      This step would include the psample and act_sample drivers into the sonic-linux-kernel.
      Also, it would install the psample.ko and act_sample.ko in a sonic-vs target at the start-up time.

    • Using sonic-utilities: Add support for sFlow sonic-utilities#592 changes, use the CLIs to configure sflow globally and on a port.

    • Thereafter, use the show CLI to verify the config changes made.

    • Pump traffic into the port where sampling is configured.

    • Kernel would generate NETLINK messages, containing the packet samples, and send them to the hsflowd daemon. At hsflowd side, we would be able to see the incoming packet samples.

  • Description for the changelog

    • Update: Added psample driver into the sonic kernel, which enables
      packet sampling in the vs environment
    • Update: Added act_sample driver into the sonic kernel, which enables 'sample' action
      for the 'tc' command

Signed-off-by: Rakesh Datta [email protected]

@rakeshdatta rakeshdatta changed the title [WIP]: For sflow feature, backport psample and act_sample drivers, needed for sonic-vs platform For sflow feature, backport psample and act_sample drivers, needed for sonic-vs platform Aug 5, 2019
@prsunny
Copy link

prsunny commented Aug 6, 2019

@marian-pritsak to review

@lguohan lguohan changed the title For sflow feature, backport psample and act_sample drivers, needed for sonic-vs platform [sflow]: backport psample and act_sample drivers, needed for sonic-vs platform Aug 10, 2019
@lguohan lguohan merged commit feb786b into sonic-net:master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants