Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce switchover when target state is standby AND mux mode is standby #281

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

zjswhhh
Copy link
Contributor

@zjswhhh zjswhhh commented Dec 6, 2024

Description of PR

Summary:
Fixes # (issue)
Enforce switchover when target state is standby AND mux mode is standby.

sign-off: Jing Zhang [email protected]

Type of change

  • Bug fix
  • New feature
  • Doc/Design
  • Unit test

Approach

What is the motivation for this PR?

Soc agent can always restart and set the forwarding state to default "active" on host side. If this happens during ToR maintenance ( mux mode != auto), we still need to correct the state to "standby".

Work item tracking
  • Microsoft ADO (number only):
    30158450

How did you do it?

How did you verify/test it?

UT

Any platform specific information?

Documentation

@zjswhhh zjswhhh marked this pull request as ready for review December 6, 2024 19:48
@zjswhhh zjswhhh requested review from lolyu and yxieca December 6, 2024 19:49
@zjswhhh zjswhhh linked an issue Dec 6, 2024 that may be closed by this pull request
@zjswhhh zjswhhh merged commit ccd52d0 into sonic-net:master Dec 9, 2024
9 checks passed
@zjswhhh zjswhhh deleted the soc_agent_restart branch December 9, 2024 18:29
mssonicbld pushed a commit to mssonicbld/sonic-linkmgrd that referenced this pull request Dec 10, 2024
…andby` (sonic-net#281)

Description of PR
Summary:
Fixes # (issue)
Enforce switchover when target state is standby AND mux mode is standby.

sign-off: Jing Zhang [email protected]

Type of change
 Bug fix
 New feature
 Doc/Design
 Unit test
Approach
What is the motivation for this PR?
Soc agent can always restart and set the forwarding state to default "active" on host side. If this happens during ToR maintenance ( mux mode != auto), we still need to correct the state to "standby".

Work item tracking
Microsoft ADO (number only):
30158450
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #283

@bingwang-ms
Copy link

@kperumalbfn Please handle the cherry-pick for 202411 branch

mssonicbld pushed a commit to mssonicbld/sonic-linkmgrd that referenced this pull request Dec 10, 2024
…andby` (sonic-net#281)

Description of PR
Summary:
Fixes # (issue)
Enforce switchover when target state is standby AND mux mode is standby.

sign-off: Jing Zhang [email protected]

Type of change
 Bug fix
 New feature
 Doc/Design
 Unit test
Approach
What is the motivation for this PR?
Soc agent can always restart and set the forwarding state to default "active" on host side. If this happens during ToR maintenance ( mux mode != auto), we still need to correct the state to "standby".

Work item tracking
Microsoft ADO (number only):
30158450
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #284

mssonicbld pushed a commit that referenced this pull request Dec 10, 2024
…andby` (#281)

Description of PR
Summary:
Fixes # (issue)
Enforce switchover when target state is standby AND mux mode is standby.

sign-off: Jing Zhang [email protected]

Type of change
 Bug fix
 New feature
 Doc/Design
 Unit test
Approach
What is the motivation for this PR?
Soc agent can always restart and set the forwarding state to default "active" on host side. If this happens during ToR maintenance ( mux mode != auto), we still need to correct the state to "standby".

Work item tracking
Microsoft ADO (number only):
30158450
mssonicbld pushed a commit that referenced this pull request Dec 10, 2024
…andby` (#281)

Description of PR
Summary:
Fixes # (issue)
Enforce switchover when target state is standby AND mux mode is standby.

sign-off: Jing Zhang [email protected]

Type of change
 Bug fix
 New feature
 Doc/Design
 Unit test
Approach
What is the motivation for this PR?
Soc agent can always restart and set the forwarding state to default "active" on host side. If this happens during ToR maintenance ( mux mode != auto), we still need to correct the state to "standby".

Work item tracking
Microsoft ADO (number only):
30158450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dualtor-aa] ToR local state stuck in standby
6 participants