-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce switchover when target state is standby
AND mux mode is standby
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
approved these changes
Dec 6, 2024
lolyu
approved these changes
Dec 8, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Dec 10, 2024
…andby` (sonic-net#281) Description of PR Summary: Fixes # (issue) Enforce switchover when target state is standby AND mux mode is standby. sign-off: Jing Zhang [email protected] Type of change Bug fix New feature Doc/Design Unit test Approach What is the motivation for this PR? Soc agent can always restart and set the forwarding state to default "active" on host side. If this happens during ToR maintenance ( mux mode != auto), we still need to correct the state to "standby". Work item tracking Microsoft ADO (number only): 30158450
Cherry-pick PR to 202405: #283 |
@kperumalbfn Please handle the cherry-pick for 202411 branch |
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Dec 10, 2024
…andby` (sonic-net#281) Description of PR Summary: Fixes # (issue) Enforce switchover when target state is standby AND mux mode is standby. sign-off: Jing Zhang [email protected] Type of change Bug fix New feature Doc/Design Unit test Approach What is the motivation for this PR? Soc agent can always restart and set the forwarding state to default "active" on host side. If this happens during ToR maintenance ( mux mode != auto), we still need to correct the state to "standby". Work item tracking Microsoft ADO (number only): 30158450
Cherry-pick PR to 202411: #284 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 10, 2024
…andby` (#281) Description of PR Summary: Fixes # (issue) Enforce switchover when target state is standby AND mux mode is standby. sign-off: Jing Zhang [email protected] Type of change Bug fix New feature Doc/Design Unit test Approach What is the motivation for this PR? Soc agent can always restart and set the forwarding state to default "active" on host side. If this happens during ToR maintenance ( mux mode != auto), we still need to correct the state to "standby". Work item tracking Microsoft ADO (number only): 30158450
mssonicbld
pushed a commit
that referenced
this pull request
Dec 10, 2024
…andby` (#281) Description of PR Summary: Fixes # (issue) Enforce switchover when target state is standby AND mux mode is standby. sign-off: Jing Zhang [email protected] Type of change Bug fix New feature Doc/Design Unit test Approach What is the motivation for this PR? Soc agent can always restart and set the forwarding state to default "active" on host side. If this happens during ToR maintenance ( mux mode != auto), we still need to correct the state to "standby". Work item tracking Microsoft ADO (number only): 30158450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Enforce switchover when target state is
standby
AND mux mode isstandby
.sign-off: Jing Zhang [email protected]
Type of change
Approach
What is the motivation for this PR?
Soc agent can always restart and set the forwarding state to default "active" on host side. If this happens during ToR maintenance ( mux mode !=
auto
), we still need to correct the state to "standby".Work item tracking
30158450
How did you do it?
How did you verify/test it?
UT
Any platform specific information?
Documentation