Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[active-active] Wrong table name used for toggling PEER's forwarding state #101

Closed
zjswhhh opened this issue Aug 1, 2022 · 1 comment · Fixed by sonic-net/sonic-platform-daemons#281
Closed

[active-active] Wrong table name used for toggling PEER's forwarding state #101

zjswhhh opened this issue Aug 1, 2022 · 1 comment · Fixed by sonic-net/sonic-platform-daemons#281
Assignees
@lolyu
Labels
bug Something isn't working

Comments

@zjswhhh
Copy link
Contributor

zjswhhh commented Aug 1, 2022 •
edited
Loading 

admin@svcstr-7050-acs-1:~$ redis-cli -n 0 keys *PEER*
1) "HW_FORWARDING_STATE_PEER_KEY_SET"
2) "_HW_FORWARDING_STATE_PEER:Ethernet20"

The table name should be HW_FORWARDING_STATE.
https://github.com/sonic-net/sonic-linkmgrd/blob/master/src/DbInterface.h#L54
@zjswhhh zjswhhh mentioned this issue Aug 2, 2022
Merged
5 tasks
@lolyu lolyu mentioned this issue Aug 8, 2022
Merged
5 tasks
@zjswhhh
Copy link
Contributor Author

zjswhhh commented Aug 9, 2022

The behavior above is actually expected as linkmgrd uses ProducerStateTable. But the app db update was never consumed by ycabled (ycabled used a different table name), hence never updated.

@lolyu lolyu mentioned this issue Aug 10, 2022
Merged
@lolyu lolyu self-assigned this Aug 10, 2022
@lolyu lolyu added the bug Something isn't working label Aug 10, 2022
yxieca pushed a commit to sonic-net/sonic-platform-daemons that referenced this issue Aug 10, 2022
@lolyu
Correct the peer forwarding state table (#281)
c7b7543 
Description
Fixes: sonic-net/sonic-linkmgrd#101

ycabled failed to toggle peer forwarding state for active-active ports.
Use ConsumerStateTable to listen to HW_FORWARDING_STATE_PEER.

Signed-off-by: Longxiang Lyu [email protected]

Motivation and Context
As the description

How Has This Been Tested?
On a dualtor-mixed testbed, shutdown a port on upper ToR, verified the lower ToR could toggle the nic_simulator upper ToR forwarding state to standby.

Signed-off-by: Longxiang Lyu <[email protected]>
yxieca pushed a commit to sonic-net/sonic-platform-daemons that referenced this issue Aug 10, 2022
@lolyu @yxieca
Correct the peer forwarding state table (#281)
d150229 
Description
Fixes: sonic-net/sonic-linkmgrd#101

ycabled failed to toggle peer forwarding state for active-active ports.
Use ConsumerStateTable to listen to HW_FORWARDING_STATE_PEER.

Signed-off-by: Longxiang Lyu [email protected]

Motivation and Context
As the description

How Has This Been Tested?
On a dualtor-mixed testbed, shutdown a port on upper ToR, verified the lower ToR could toggle the nic_simulator upper ToR forwarding state to standby.

Signed-off-by: Longxiang Lyu <[email protected]>
lolyu added a commit to sonic-net/sonic-mgmt that referenced this issue Aug 17, 2022
@lolyu
[dualtor][active-active] Enable link down testcases (#6120)
880f9f0 
Approach
What is the motivation for this PR?
Enable link down scenario for dualtor active-active testcases.

Signed-off-by: Longxiang Lyu [email protected]

How did you do it?
Modify port shutdown fixtures to shutdown ports based on the parameterized cable type.
Enable test_active_link_down_upstream

How did you verify/test it?
Failed because now linkmgrd fails toggle peer forwarding state, as sonic-net/sonic-linkmgrd#101

Any platform specific information?
allen-xf pushed a commit to allen-xf/sonic-mgmt that referenced this issue Oct 28, 2022
@lolyu
[dualtor][active-active] Enable link down testcases (sonic-net#6120)
02f2ac8 
Approach
What is the motivation for this PR?
Enable link down scenario for dualtor active-active testcases.

Signed-off-by: Longxiang Lyu [email protected]

How did you do it?
Modify port shutdown fixtures to shutdown ports based on the parameterized cable type.
Enable test_active_link_down_upstream

How did you verify/test it?
Failed because now linkmgrd fails toggle peer forwarding state, as sonic-net/sonic-linkmgrd#101

Any platform specific information?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolyu lolyu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct the peer forwarding state table lolyu/sonic-platform-daemons
2 participants
@zjswhhh @lolyu