-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Clock] Update system timezone via ConfigDB #57
Conversation
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
…gs according to the new timezone. Signed-off-by: Yevhen Fastiuk <[email protected]>
de6d781
to
ae2f499
Compare
@fastiuk please update the PR description and the PR subject. this PR is not for CLI but for a backend. |
The fact that this code in hostcfgd is needed, does that imply that the BIOS clock is NOT synchronized with the OS settings? Which further implies that during reboot, the clock would be wrong until hostcfgd fixes the date/time? This is not safe for upgrades. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this change?
No, it doesn't. The code reflected here is to update the system timezone, and it doesn't touch system time. |
Which one, I don't see any code snippet |
Ping here |
Please confirm if there are tabs in the diff. If so, please change to white spaces. |
no tabs in diff |
hld #1219
closes #1171
This PR brings functionality that allows us to update the system timezone by writing to the timezone field of the DEVICE_METADATA table of ConfigDB.
The clock CLI implemented in #2793 uses that functionality as the backend.