Use ASICx suffix in DB target path only if the device is multi-asic #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
judyjoseph
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
LGTM, any unit tests needs a fix to cover this change ?
@judyjoseph @zbud-msft will add sonic-mgmt test case for this. It will be hard to cover this via UT.
zbud-msft
approved these changes
Jan 22, 2024
zbud-msft
reviewed
Jan 22, 2024
|
|
||
| if len(targetname) > 1 { | ||
| // ASIC Suffix is only used in case if device is multi-asic/namespace | ||
| if isMultiNamespace && len(targetname) > 1 { |
There was a problem hiding this comment.
"Before the fix client was getting error. After change it is getting data as expected." Can we get UT for this case?
|
@zbud-msft please add ADO number to this PR. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
For supporting multi-asic as described here: sonic-net/sonic-telemetry#77 we added support to handle
ASICxsuffix in the target DB path. We should only use that suffix if the device is multi-asic else we can ignore it. This PR handle this case.ADO: 27085442
Why I did:
Telemetry Client can pass
ASICxeven for single asic device. To protect from that condition this change has been added.How I verify:
Manually Verified . Before the fix client was getting error. After change it is getting data as expected.