Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Fix typo and missing file in buffer templates #9537

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

stephenxs
Copy link
Collaborator

Why I did it

Fix typo and missing files in SN3800 and SN4600C's buffer templates

Signed-off-by: Stephen Sun [email protected]

How I did it

  1. ingress_lossless_xoff_size => ingress_lossless_pool_xoff
  2. add missing files for SN4600C-D100C12S2

How to verify it

Deploy the fix and verify whether the device can be up.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

1. ingress_lossless_xoff_size => ingress_lossless_pool_xoff
2. add missing files for SN4600C-D100C12S2

Signed-off-by: Stephen Sun <[email protected]>
@stephenxs stephenxs added Request for 202106 Branch Request for 202111 Branch For PRs being requested for 202111 branch labels Dec 17, 2021
@stephenxs
Copy link
Collaborator Author

stephenxs commented Dec 17, 2021

Cherry-picking to 202106/202111 depends on PR #9215 to be cherry-picked.

@yxieca yxieca merged commit 34be53a into sonic-net:master Dec 20, 2021
@stephenxs stephenxs deleted the fix-4600c-d112c8-xoff branch December 20, 2021 23:14
qiluo-msft pushed a commit that referenced this pull request Dec 23, 2021
…9537)

Why I did it
Fix typo and missing files in SN3800 and SN4600C's buffer templates

How I did it
ingress_lossless_xoff_size => ingress_lossless_pool_xoff add missing files for SN4600C-D100C12S2

How to verify it
Deploy the fix and verify whether the device can be up.

Signed-off-by: Stephen Sun <[email protected]>
@judyjoseph
Copy link
Contributor

Please raise a new PR for 202111 branch, as this patch cannot be cleanly cherry-picked.

@stephenxs
Copy link
Collaborator Author

Please raise a new PR for 202111 branch, as this patch cannot be cleanly cherry-picked.

@judyjoseph It depends on #9215.
I saw that PR has just been cherry-picked so can you please retry it?
thanks.

judyjoseph pushed a commit that referenced this pull request Jan 9, 2022
…9537)

Why I did it
Fix typo and missing files in SN3800 and SN4600C's buffer templates

How I did it
ingress_lossless_xoff_size => ingress_lossless_pool_xoff add missing files for SN4600C-D100C12S2

How to verify it
Deploy the fix and verify whether the device can be up.

Signed-off-by: Stephen Sun <[email protected]>
arlakshm pushed a commit that referenced this pull request Mar 1, 2022
…9537)

Why I did it
Fix typo and missing files in SN3800 and SN4600C's buffer templates

How I did it
ingress_lossless_xoff_size => ingress_lossless_pool_xoff add missing files for SN4600C-D100C12S2

How to verify it
Deploy the fix and verify whether the device can be up.

Signed-off-by: Stephen Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants