-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yang model support for SRV6 CRM #9487
Conversation
blocks #9383 merge |
@prsunny @qiluo-msft Could you please review and merge this. |
@qiluo-msft @zhangyanzhao This is a very import PR as it resolves break in yang. Can we expedite? root@r-panther-13:~# config interface breakout Ethernet0 4x10G[25G] Running Breakout Mode : 1x100G[50G,40G,25G,10G] Ports to be deleted : After running Logic to limit the impact Final list of ports to be deleted : |
@@ -115,5 +115,43 @@ | |||
}, | |||
"MPLS_NH_WITH_CORRECT_USED_VALUE": { | |||
"desc": "MPLS_NH_WITH_CORRECT_USED_VALUE no failure." | |||
}, | |||
"SRV6_MY_SID_ENTRY_WITH_WRONG_THRESHOLD_TYPE": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[](http://example.com/codeflow?start=0&length=4)
This file is mixing tabs and spaces. Could you reformat the whole file?
description "CRM threshold support for SRV6 my_sid entries"; | ||
|
||
must "(((current()='PERCENTAGE' or current()='percentage') and | ||
../srv6_my_sid_entry_high_threshold<100 and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kperumalbfn This is yang model PR related to new fields "srv6_my_sid_entry", "srv6_nexthop" |
Yes @qiluo-msft. This is model for SRV6 CRM. Will address your comments and update the PR. |
Need SRv6 feature experts to help on the review. |
Need engage with SRv6 feature owner to check |
sent mail to Reshma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from "quilo-msft" comments, diffs look fine.
Why I did it
To support Yang models for SRV6 CM
How I did it
Added yang models for SRV6 MY_SID_ENTRY and Nexthop
How to verify it
Added SRV6 CRM yang tests.
Which release branch to backport (provide reason below if selected)
202111