Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yang model support for SRV6 CRM #9487

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

kperumalbfn
Copy link
Contributor

Why I did it

To support Yang models for SRV6 CM

How I did it

Added yang models for SRV6 MY_SID_ENTRY and Nexthop

How to verify it

Added SRV6 CRM yang tests.

Which release branch to backport (provide reason below if selected)

202111

@zhangyanzhao
Copy link
Collaborator

blocks #9383 merge

@kperumalbfn
Copy link
Contributor Author

@prsunny @qiluo-msft Could you please review and merge this.

@dgsudharsan
Copy link
Collaborator

@qiluo-msft @zhangyanzhao This is a very import PR as it resolves break in yang. Can we expedite?

root@r-panther-13:~# config interface breakout Ethernet0 4x10G[25G]
Do you want to Breakout the port, continue? [y/N]: y

Running Breakout Mode : 1x100G[50G,40G,25G,10G]
Target Breakout Mode : 4x10G[25G]

Ports to be deleted :
{
"Ethernet0": "100000"
}
Ports to be added :
{
"Ethernet0": "10000",
"Ethernet1": "10000",
"Ethernet2": "10000",
"Ethernet3": "10000"
}

After running Logic to limit the impact

Final list of ports to be deleted :
{
"Ethernet0": "100000"
}
Final list of ports to be added :
{
"Ethernet0": "10000",
"Ethernet1": "10000",
"Ethernet2": "10000",
"Ethernet3": "10000"
}
Note: Below table(s) have no YANG models:
KDUMP, SNMP, SNMP_COMMUNITY, WJH, WJH_CHANNEL, XCVRD_LOG,
sonic_yang(3):All Keys are not parsed in CRM
dict_keys(['srv6_my_sid_entry_high_threshold', 'srv6_my_sid_entry_low_threshold', 'srv6_my_sid_entry_threshold_type', 'srv6_nexthop_high_threshold', 'srv6_nexthop_low_threshold', 'srv6_nexthop_threshold_type'])
sonic_yang(3):exceptionList:[]
sonic_yang(3):Data Loading Failed:All Keys are not parsed in CRM
dict_keys(['srv6_my_sid_entry_high_threshold', 'srv6_my_sid_entry_low_threshold', 'srv6_my_sid_entry_threshold_type', 'srv6_nexthop_high_threshold', 'srv6_nexthop_low_threshold', 'srv6_nexthop_threshold_type'])
Data Loading Failed
All Keys are not parsed in CRM
dict_keys(['srv6_my_sid_entry_high_threshold', 'srv6_my_sid_entry_low_threshold', 'srv6_my_sid_entry_threshold_type', 'srv6_nexthop_high_threshold', 'srv6_nexthop_low_threshold', 'srv6_nexthop_threshold_type'])
ConfigMgmt Class creation failed
Failed to break out Port. Error: Failed to load the config. Error: ConfigMgmtDPB Class creation failed

@@ -115,5 +115,43 @@
},
"MPLS_NH_WITH_CORRECT_USED_VALUE": {
"desc": "MPLS_NH_WITH_CORRECT_USED_VALUE no failure."
},
"SRV6_MY_SID_ENTRY_WITH_WRONG_THRESHOLD_TYPE": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[](http://example.com/codeflow?start=0&length=4)

This file is mixing tabs and spaces. Could you reformat the whole file?

description "CRM threshold support for SRV6 my_sid entries";

must "(((current()='PERCENTAGE' or current()='percentage') and
../srv6_my_sid_entry_high_threshold<100 and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<

<= ?

@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Dec 11, 2021

@kperumalbfn This is yang model PR related to new fields "srv6_my_sid_entry", "srv6_nexthop"

@kperumalbfn
Copy link
Contributor Author

Yes @qiluo-msft. This is model for SRV6 CRM. Will address your comments and update the PR.

@zhangyanzhao
Copy link
Collaborator

Need SRv6 feature experts to help on the review.

@zhangyanzhao
Copy link
Collaborator

Need engage with SRv6 feature owner to check

@zhangyanzhao
Copy link
Collaborator

sent mail to Reshma

Copy link
Collaborator

@svshah-intel svshah-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from "quilo-msft" comments, diffs look fine.

@qiluo-msft qiluo-msft merged commit d8f30c7 into sonic-net:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants