Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Accton wedge100bf_32qs platform to SONiC master #9257

Merged
merged 6 commits into from
Feb 18, 2022

Conversation

alvinkaiwei
Copy link
Contributor

@alvinkaiwei alvinkaiwei commented Nov 15, 2021

Why I did it

This pull request is based on wedge100bf_32x.

The components on the mainboard are the same as wedge100bf_32x, except for tofino 32Q and COMe models, so it refers to wedge100bf_32x to create new model: wedge100bf_32qs.

Signed-off-by: alvin_feng [email protected]

How I did it

It refers to wedge100bf_32x to create new model: wedge100bf_32qs.

How to verify it

Verify on the 32qs device.
show interface status
sfputil show eeprom
sfputil show presence
show platform syseeprom
show platform psustatus

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

This pull request is based on wedge100bf_32x.

The components on the mainboard are the same as wedge100bf_32x, except for tofino 32Q and COMe models, so it refers to wedge100bf_32x to create new model: wedge100bf_32qs.

Signed-off-by: alvin_feng <[email protected]>
@alvinkaiwei alvinkaiwei requested a review from lguohan as a code owner November 15, 2021 01:59
@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2021

This pull request introduces 2 alerts when merging 8ad0e14 into db0b789 - view on LGTM.com

new alerts:

  • 2 for Wrong number of arguments in a class instantiation

Signed-off-by: alvin_feng <[email protected]>
@ShoneWu
Copy link

ShoneWu commented Nov 24, 2021

@lguohan
May you please help review if those medications are OK?
We have customers using SONiC need them on their White Box.
Many thanks.

@akokhan
Copy link
Contributor

akokhan commented Dec 8, 2021

@alvinkaiwei , do we need a separate PR for 202012? Can't you just update this PR's description with an original SONiC PR template and in "Which release branch to backport" section mark 202012 ? Please see how it's done in "#9465"
In such case #9065 probably can be closed. Please check.

@alvinkaiwei
Copy link
Contributor Author

@alvinkaiwei , do we need a separate PR for 202012? Can't you just update this PR's description with an original SONiC PR template and in "Which release branch to backport" section mark 202012 ? Please see how it's done in "#9465" In such case #9065 probably can be closed. Please check.

@akokhan,The definition of the platform.json file is different between 202012 and master.
If we use platform.json of master on SONiC-202012, it will cause compilation errors by \src\sonic-device-data\tests\platform_json_checker.

@alvinkaiwei
Copy link
Contributor Author

@alvinkaiwei , do we need a separate PR for 202012? Can't you just update this PR's description with an original SONiC PR template and in "Which release branch to backport" section mark 202012 ? Please see how it's done in "#9465" In such case #9065 probably can be closed. Please check.

@akokhan,The definition of the platform.json file is different between 202012 and master. If we use platform.json of master on SONiC-202012, it will cause compilation errors by \src\sonic-device-data\tests\platform_json_checker.

We have discussed this issue with the intel team, so we will close PR#9065 and mark it to be cherry-picked into 202012/202106/202111.

@ShoneWu
Copy link

ShoneWu commented Jan 21, 2022

@akokhan May you please help review this PR again? EC customer is waiting for that.
Many thanks.

akokhan
akokhan previously approved these changes Jan 24, 2022
@alvinkaiwei
Copy link
Contributor Author

alvinkaiwei commented Jan 25, 2022

@lguohan Please help to check if this modification can be merged into SONiC master. Thanks!

@akokhan
Copy link
Contributor

akokhan commented Jan 25, 2022

Jus FYI
The changes similar to the following may also be needed here
Please check

…rect generating BUFFER_QUEUE values in DB.

Signed-off-by: alvin_feng <[email protected]>
@alvinkaiwei
Copy link
Contributor Author

alvinkaiwei commented Jan 27, 2022

Jus FYI The changes similar to the following may also be needed here Please check

@akokhan I have modified platform.json to avoid platform TCs issues and changes for correct generating BUFFER_QUEUE values in DB.

@ShoneWu
Copy link

ShoneWu commented Feb 11, 2022

@akokhan Alvin already add all the modifications you suggested and passed the checks. May you please help merge it to master and branches, 202012, 202106, and 202111.
Many thanks.

@ShoneWu
Copy link

ShoneWu commented Feb 18, 2022

@lguohan @akokhan May you please confirm this PR? It's really pending for a long time. Many thanks.

@prgeor prgeor merged commit d2f6fe7 into sonic-net:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants