Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix pip redis version #8999

Closed
wants to merge 1 commit into from

Conversation

qiluo-msft
Copy link
Collaborator

Intention is same as #8997, but using a straightforward method.

Why I did it

Fix a recent build error introduced by a pre-release redis-py. This is a general issue because python setup.py install (ie easy_instal) does not ignore pre-release versions.

[ building ] [ target/python-wheels/redis_dump_load-1.1-py2-none-any.whl ] 
Applying patch ../redis-dump-load.patch/0001-Use-pipelines-when-dumping-52.patch
patching file redisdl.py

Applying patch ../redis-dump-load.patch/0002-Fix-setup.py-for-test-and-bdist_wheel.patch
patching file setup.py

Now at patch ../redis-dump-load.patch/0002-Fix-setup.py-for-test-and-bdist_wheel.patch
[ finished ] [ target/python-wheels/redis_dump_load-1.1-py2-none-any.whl ] 
[ FAIL LOG START ] [ target/python-wheels/redis_dump_load-1.1-py2-none-any.whl ]
[ REASON ] :      target/python-wheels/redis_dump_load-1.1-py2-none-any.whl does not exist  
[ FLAGS  FILE    ] : [] 
[ FLAGS  DEPENDS ] : [broadcom] 
[ FLAGS  DIFF    ] : [broadcom ] 
/sonic/src/redis-dump-load /sonic
running test
Searching for redis
Reading https://pypi.org/simple/redis/
Downloading https://files.pythonhosted.org/packages/62/ab/6491b41bbfb938afbc4424164983d1def3c59434c77e8cf710213be03fed/redis-4.0.0b1.tar.gz#sha256=f778e27d542ba1f43a6b02a80fa904d8a49e5d3b824ec5fb3f0d5cbdba11e4cd
Best match: redis 4.0.0b1
Processing redis-4.0.0b1.tar.gz
Writing /tmp/easy_install-ZCmBMQ/redis-4.0.0b1/setup.cfg
Running redis-4.0.0b1/setup.py -q bdist_egg --dist-dir /tmp/easy_install-ZCmBMQ/redis-4.0.0b1/egg-dist-tmp-QcQyOe
Traceback (most recent call last):
  File "setup.py", line 41, in <module>
    'Topic :: System :: Archiving',
  File "/usr/lib/python2.7/dist-packages/setuptools/__init__.py", line 145, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@qiluo-msft qiluo-msft requested a review from lguohan as a code owner October 18, 2021 16:16
@qiluo-msft qiluo-msft marked this pull request as draft October 19, 2021 03:59
@lguohan lguohan closed this Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants