Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACL] enable ACL FC when genereting config from minigraph but disable by default #8908

Merged
merged 5 commits into from
Nov 11, 2021

Conversation

stepanblyschak
Copy link
Collaborator

@stepanblyschak stepanblyschak commented Oct 6, 2021

Why I did it

To support ACL counters on Flex Counter Infrastructure.

How I did it

Enable ACL FC in init_cfg and minigraph. Disable when genereting configuration from preset.

How to verify it

Together with depends PRs. Run ACL/Everflow test suite.

DEPENDS ON: sonic-net/sonic-swss-common#533 sonic-net/sonic-sairedis#953 sonic-net/sonic-swss#1943
HLD: sonic-net/SONiC#857

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@stepanblyschak stepanblyschak changed the title [ACL] enable ACL FC when genereting config from minigraph but disable [ACL] enable ACL FC when genereting config from minigraph but disable by default Oct 6, 2021
@liat-grozovik
Copy link
Collaborator

@bingwang-ms could you please help to review?

@bingwang-ms bingwang-ms merged commit a2c2d67 into sonic-net:master Nov 11, 2021
'ACL': {
'FLEX_COUNTER_STATUS': 'disable',
'FLEX_COUNTER_DELAY_STATUS': 'true',
'POLL_INTERVAL': '10000'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stepanblyschak Could you please help? What could be the possible POLL_INTERVAL range?

alexrallen added a commit to alexrallen/sonic-buildimage that referenced this pull request Nov 25, 2021
@stepanblyschak stepanblyschak deleted the acl-enable-fc branch September 23, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants