-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature yang changes #7955
Feature yang changes #7955
Conversation
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
src/sonic-yang-models/tests/yang_model_tests/tests_config/feature.json
Outdated
Show resolved
Hide resolved
not ready for review, need move it back to "To be Reviewed column" |
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Arvind will handle the comments from Venkat. |
@arlakshm In the mgmt VRF YANG, boolean value is represented as "true" in the below file, please try this for your case as well. |
@arlakshm please address the comments from Venkat. Thanks. |
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
The backend python code expects "True" or "False" I think change to "true" may not work. |
boolean type is represented as "true/"false" in the table (MGMT VRF, LLDP..etc) fields, can we change the backend to accept "true"/"false" to be consistent. |
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
leaf high_mem_alert { | ||
description "This configuration controls the trigger to generate | ||
alert on high memory utilization"; | ||
type stypes:feature_state; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arlakshm does always_enabled applies for high_mem_alert ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arlakshm does always_enabled applies for high_mem_alert ?
I think it is OK to let high_mem_alert
support the option always_enabled
.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan [email protected]
Why I did it
Add yang model for Feature configuration
How I did it
Add
feature.yang
and unit testsHow to verify it
Compile
target/python-wheels/sonic_yang_models-1.0-py3-none-any.whl
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)