-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry docker] add memory and memory swap limits #7062
Conversation
@pra-moh - thanks, please add testing done. |
what is memory-swap? |
Based on docker documentation: https://docs.docker.com/config/containers/resource_constraints/#prevent-a-container-from-using-swap |
please describe what kind of testing have you done? besides, we do not use swap at all on switches. it should be set to zero. |
can you update the description? |
can you update the description to say how 500m is derived? |
Let's revise the memory cap based on latest data. Thanks. |
bad pr, oom triggered system reboot. |
let us revert it. heard about the issue after s/o. |
We need "--oom-kill-disable" option when we limit the memory so no kernel panic. On our testing we found that as we move to Memory threshold CPU utilization start going over 100%+ by telemetry and also docker start getting very slow/unresponsive. High CPU will impact overall system. Plan is to have monit itself check for telemetry docker memory threshold and if exceed this |
#### Why I did it Fix https://github.com/Azure/sonic-telemetry/issues/71 #### How I did it Added memory limit for telemetry docker. Historical docker memory usage shows telemetry docker consuming 150-200MB memory. Adding some extra buffer.
…et#7062)" (sonic-net#7582) This reverts commit 0c59278.
Why I did it
Fix https://github.com/Azure/sonic-telemetry/issues/71
How I did it
Added memory limit for telemetry docker.
Historical docker memory usage shows telemetry docker consuming 150-200MB memory. Adding some extra buffer.
How to verify it
Build and install image with change:
docker memory for telemetry changes to assigned value:
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)