Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of stopping dependent services of SWSS on 201911 #6756

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Change the order of stopping dependent services of SWSS on 201911 #6756

merged 1 commit into from
Feb 18, 2021

Conversation

shlomibitton
Copy link
Contributor

@shlomibitton shlomibitton commented Feb 10, 2021

Signed-off-by: Shlomi Bitton [email protected]

- Why I did it
When large number of port channels (more than 64) is configured, a config reload command might ends with not all port channel configured and up. Further debug shows that unloading the port channels on the ASIC driver take a lot of time.
With the change, deleting all port channels before the syncd restart will free resources better and the ASIC driver will unload all netdev fast and the operation will execute properly.

- How I did it
Change the order of dependent services of SWSS.

- How to verify it
Before the fix:

  • Configure more than 80 port channel each with IP address.
  • Run 'config reload' command. ASIC driver failure observed and not all port channels are configured properly and up.

After the fix:

  • Configure more than 80 port channel each with IP address.
  • Run 'config reload' command. No errors on ASIC driver, all port channel configured and up.

Which release branch to backport (provide reason below if selected)
[ ] 201811
[ ] 201911
[ ] 202006
[ ] 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Shlomi Bitton <[email protected]>
@liat-grozovik liat-grozovik requested a review from abdosi February 14, 2021 08:24
@liat-grozovik
Copy link
Collaborator

@abdosi please review. we believe this is needed for 201911 production env.

@shlomibitton shlomibitton changed the title Change the order of stopping dependent services of SWSS Change the order of stopping dependent services of SWSS on 201911 Feb 14, 2021
@abdosi
Copy link
Contributor

abdosi commented Feb 16, 2021

@yxieca and @judyjoseph please review this.

@abdosi abdosi requested review from judyjoseph and yxieca February 16, 2021 16:52
@judyjoseph
Copy link
Contributor

The change looks ok, Could you add the results you observed with and without this change. thanks.

@liat-grozovik
Copy link
Collaborator

@judyjoseph the comment was updated with more information and how it was verified. please let us know if something is missing, otherwise we strongly suggest to take it to 201911

@abdosi abdosi merged commit 4a1742e into sonic-net:201911 Feb 18, 2021
@shlomibitton shlomibitton deleted the shlomi_stop_teamd_201911 branch March 24, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants