Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broadcom]: Update SAI package to 2.1.5.1-8 #649

Merged
merged 1 commit into from
May 31, 2017
Merged

[Broadcom]: Update SAI package to 2.1.5.1-8 #649

merged 1 commit into from
May 31, 2017

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented May 31, 2017

Add config_checker/permitted_list
Please check etc/bcm/ folder to check the README.msft file!

Add config_checker/permitted_list
Please check etc/bcm/ folder to check the README.msft file!
@stcheng stcheng merged commit a5c0dff into sonic-net:master May 31, 2017
@stcheng stcheng deleted the sai branch May 31, 2017 17:57
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Oct 24, 2018
* 6e76e9b 2018-10-22 | [vstest]: fix redis mount point with --dvsname option (sonic-net#654) (HEAD, origin/master, origin/HEAD) [lguohan]
* 3d4bed1 2018-10-22 | [mirrororch]: Fix bug when no need to update session type (sonic-net#648) [Shuotian Cheng]
*   4bf28ed 2018-10-22 | Merge pull request sonic-net#649 from lguohan/vstest [lguohan]
|\
| * 8620a51 2018-10-22 | [vstest]: disable ipv6 in test_crm.py::test_CrmFdbEntry [Guohan Lu]
| * f684d65 2018-10-21 | change mode to 644 for test_setro.py [Guohan Lu]
| * 51e0d40 2018-10-22 | Enable aclfield.data for SAI_DTEL_ATTR_INT_L4_DSCP [Guohan Lu]
| * 9290950 2018-10-21 | use unique directory to mount redis.sock [Guohan Lu]
| * 7d1b09e 2018-10-21 | add --keeptb option to keep testbed after test [Guohan Lu]
| * 6ee779c 2018-10-22 | gather logs from vs container [Guohan Lu]
| * 9b49555 2018-10-21 | make sure delete the srv namespace after test [Guohan Lu]
| * e04bd2d 2018-10-20 | add testlog for all tests [Guohan Lu]
| * a2d9be4 2018-10-20 | simplify start_swss/stop_swss [Guohan Lu]
| * d76a560 2018-10-21 | add ingore object type to CountSubscribedObjects [Guohan Lu]
| * 5e2c1de 2018-10-20 | refactor test_swss_neighbor_syncup test [Guohan Lu]
| * 9e9a553 2018-10-20 | ensure vrfmgrd, teammgrd, portmgrd are running before test [Guohan Lu]
|/
* e8e3ddc 2018-10-21 | disable ipv6 for vEthernet interface in virtual switch (sonic-net#650) [lguohan]
* 7c90bb3 2018-10-19 | Fix portorch bake: get port count from db (sonic-net#645) [Qi Luo]

Signed-off-by: Guohan Lu <[email protected]>
lguohan added a commit that referenced this pull request Oct 25, 2018
* 6e76e9b 2018-10-22 | [vstest]: fix redis mount point with --dvsname option (#654) (HEAD, origin/master, origin/HEAD) [lguohan]
* 3d4bed1 2018-10-22 | [mirrororch]: Fix bug when no need to update session type (#648) [Shuotian Cheng]
*   4bf28ed 2018-10-22 | Merge pull request #649 from lguohan/vstest [lguohan]
|\
| * 8620a51 2018-10-22 | [vstest]: disable ipv6 in test_crm.py::test_CrmFdbEntry [Guohan Lu]
| * f684d65 2018-10-21 | change mode to 644 for test_setro.py [Guohan Lu]
| * 51e0d40 2018-10-22 | Enable aclfield.data for SAI_DTEL_ATTR_INT_L4_DSCP [Guohan Lu]
| * 9290950 2018-10-21 | use unique directory to mount redis.sock [Guohan Lu]
| * 7d1b09e 2018-10-21 | add --keeptb option to keep testbed after test [Guohan Lu]
| * 6ee779c 2018-10-22 | gather logs from vs container [Guohan Lu]
| * 9b49555 2018-10-21 | make sure delete the srv namespace after test [Guohan Lu]
| * e04bd2d 2018-10-20 | add testlog for all tests [Guohan Lu]
| * a2d9be4 2018-10-20 | simplify start_swss/stop_swss [Guohan Lu]
| * d76a560 2018-10-21 | add ingore object type to CountSubscribedObjects [Guohan Lu]
| * 5e2c1de 2018-10-20 | refactor test_swss_neighbor_syncup test [Guohan Lu]
| * 9e9a553 2018-10-20 | ensure vrfmgrd, teammgrd, portmgrd are running before test [Guohan Lu]
|/
* e8e3ddc 2018-10-21 | disable ipv6 for vEthernet interface in virtual switch (#650) [lguohan]
* 7c90bb3 2018-10-19 | Fix portorch bake: get port count from db (#645) [Qi Luo]

Signed-off-by: Guohan Lu <[email protected]>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
[vstest]: various vstest fixes and enhancements
abdosi added a commit that referenced this pull request Sep 3, 2020
Update the meta code to support DNAT Pool changes (#616)
[syncd] Fix notification on shutdown request (#637)
Advance the submodule head of SAI (#641)
Add new line in sai_meta_log_syncd fprintf call (#649)
Fix Warmboot Issue when upgraded Image SAI return Switch Internal
OID not accounted in previous image. (#654)
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Feb 27, 2025
…handle link notification faster. (sonic-net#649)

What I did:
Change the Orchagent redis pop batch size to 128 to handle link notification faster.

Why I did:
As part of Ixia BGP convergence test https://github.com/sonic-net/sonic-mgmt/blob/master/tests/snappi_tests/multidut/bgp/test_bgp_outbound_uplink_multi_po_flap.py we found that because of SAI programming slowness which is around 1500 Routes/sec. [Takes about approx 40sec+/- to program 60K routes across multiple iteration]
Because of above slowness even if we have Link Notification available Orchagent will not process it immediately as current OA will process 1024 Entries (Route entries in our case) before it can pick Link Notification for processing. Now 1K entries can take about 2 sec+/- and if link notification are little spread out [not back 2 back] we can have batch of 1K entries which accumulate SAI delay of 2 sec.

 To optimize Link processing and give more chance to OA to pick Link Notification we reduce OA processing to 128 entries and this helped to reduce convergence time to about overall 2 sec.

Changing OA processing from 1K to 128 entries does not have any impact of Route Programming as SAI slowness seems be tied with sequential processing at 1500 Routes per/sec. However this is helpful in processing Link Notification quicker. For our test it reduce Convergence time from about 12-15sec to 2 sec.

How I verify:

Ran above ixia test in multiple iteration with both 1024 and 128 pop batch size and compared the performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants