Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DellEMC: Z9332f change SFP detection logic #6261

Merged
merged 2 commits into from
Jan 6, 2021
Merged

DellEMC: Z9332f change SFP detection logic #6261

merged 2 commits into from
Jan 6, 2021

Conversation

aravindmani-1
Copy link
Contributor

- Why I did it

  • Dynamically change EEPROM driver based on media type.
  • Otherwise, EEPROM INFO and DOM INFO might not be fetched properly and will result in erroneous output.

- How I did it
Changed the optoe driver by reading optic EEPROM byte
- How to verify it

  • Check driver type in optic driver path(/sys/class/i2c-adapter//name.
  • Take hexdump of optic EEPROM after OIR.
  • Check sfpshow eeprom -d

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

  • Change the SFP driver based on optic type.

UT:
z9332f_sfp_detection_logic_UT.txt

- A picture of a cute animal (not mandatory but encouraged)

@aravindmani-1 aravindmani-1 marked this pull request as ready for review December 28, 2020 03:42
@aravindmani-1
Copy link
Contributor Author

retest vsimage please

3 similar comments
@aravindmani-1
Copy link
Contributor Author

retest vsimage please

@aravindmani-1
Copy link
Contributor Author

aravindmani-1 commented Dec 31, 2020 •
edited
Loading

retest vsimage please

@aravindmani-1
Copy link
Contributor Author

retest vsimage please

@aravindmani-1 aravindmani-1 reopened this Dec 31, 2020
@aravindmani-1
Copy link
Contributor Author

Team,

Can you review this PR?.

@aravindmani-1
Copy link
Contributor Author

@jleveque Can you please help to review/merge this PR?.

@jleveque jleveque merged commit 4632e0b into sonic-net:master Jan 6, 2021
@aravindmani-1 aravindmani-1 deleted the Change_sfp_detection_logic branch January 7, 2021 04:27
lguohan pushed a commit that referenced this pull request Jan 9, 2021
@aravindmani-1 @lguohan
DellEMC: Z9332f change SFP detection logic (#6261)
7305b55 
- Dynamically change EEPROM driver based on media type.
- Otherwise, EEPROM INFO and DOM INFO might not be fetched properly and will result in erroneous output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
Bug 🐛 Platform: DellEMC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aravindmani-1 @jleveque