Update sonic-cli start script and resolve package dependencies #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest broadcom please |
|
retest vsimage please |
| @@ -7,7 +7,7 @@ RUN [ -f /etc/rsyslog.conf ] && sed -ri "s/%syslogtag%/$docker_container_name#%s | |||
| ENV DEBIAN_FRONTEND=noninteractive | |||
|
|
|||
| RUN apt-get update && \ | |||
| apt-get install -y g++ python-dev libxml2 | |||
| apt-get install -y g++ python-dev libxml2 libcurl3-gnutls libpython2.7 libcjson-dev | |||
There was a problem hiding this comment.
Are not you moving to Python3 ?
There was a problem hiding this comment.
Upgrade to python3.7 in sonic-cli is in progress. A PR will be opened soon after the pending PRs related to Klish parser - sonic-net/sonic-mgmt-framework#72, sonic-net/sonic-mgmt-framework#73 - get merged.
|
retest vsimage please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
As part of mgmt-framework CLI enhancement - sonic-net/sonic-mgmt-framework#72
- How I did it
update the bash script to launch Klish
update the Dockerfile.j2 to resolve dependent packages
- How to verify it
Incremental buster build with sonic-net/sonic-mgmt-framework#72
- Which release branch to backport (provide reason below if selected)
201811
201911
202006
- Description for the changelog
Update the Klish start script:
support CLI session timeout, prompt string with hostname, disallow CLI for the root user, disallow user to enter commands in click prompt after reboot command is issued in KLISH mode
add dependent libraries for Kish parser enhancement