Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic-telemetry][sonic-mgmt-common] Update submodules #4986

Merged
merged 4 commits into from
Jul 22, 2020
Merged

[sonic-telemetry][sonic-mgmt-common] Update submodules #4986

merged 4 commits into from
Jul 22, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Jul 17, 2020 •
edited
Loading

Note: sonic-telemetry submodule update is dependent upon sonic-mgmt-common submodule update, thus updating both in this patch

@jleveque jleveque self-assigned this Jul 17, 2020
@jleveque jleveque changed the title [sonic-telemetry] Update submodule [sonic-telemetry][sonic-mgmt-common] Update submodules Jul 17, 2020
@jleveque
Copy link
Contributor Author

Retest broadcom please

@jleveque
Copy link
Contributor Author

@hui-ma, @pra-moh: The broadcom check build is failing to build sonic-telemetry. Can you please investigate which PR may have caused this?

@seiferteric seiferteric mentioned this pull request Jul 21, 2020
Merged
jleveque pushed a commit to sonic-net/sonic-telemetry that referenced this pull request Jul 21, 2020
@seiferteric
Update gnmi deps (#40)
3bd7ca3 
This was the result of running go get github.com/openconfig/gnmi

This was required to fix build issue seen in sonic-net/sonic-buildimage#4986

After adding these changes I did a make clean && rm -rf vendor in both sonic-telemetry and sonic-mgmt-common repo and was able to build.
@jleveque
Copy link
Contributor Author

Retest broadcom please

@jleveque jleveque merged commit 2890670 into sonic-net:master Jul 22, 2020
@jleveque jleveque deleted the update_telemetry branch July 22, 2020 18:51
TildenWinston pushed a commit to TildenWinston/sonic-telemetry that referenced this pull request Aug 7, 2020
@seiferteric @TildenWinston
Update gnmi deps (sonic-net#40)
9903bd2 
This was the result of running go get github.com/openconfig/gnmi

This was required to fix build issue seen in sonic-net/sonic-buildimage#4986

After adding these changes I did a make clean && rm -rf vendor in both sonic-telemetry and sonic-mgmt-common repo and was able to build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hui-ma hui-ma hui-ma approved these changes

Assignees

@jleveque jleveque

Labels
Submodule Update ⏫ telemetry 🔭
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleveque @hui-ma