[interfaces]: Do not bring up LAG members when LAG is not up #480

stcheng · 2017-04-05T21:16:43Z

Without this fix, the LAG members will be brought up. Due
to the current design of teamd, interfaces cannot join teamd
when they are up.

Signed-off-by: Shuotian Cheng [email protected]

- Without this fix, the LAG members will be brought up. Due to the current design of teamd, interfaces cannot join teamd when they are up. Signed-off-by: Shuotian Cheng <[email protected]>

lguohan · 2017-04-05T21:27:01Z

files/image_config/interfaces/interfaces.j2

@@ -76,7 +76,7 @@ auto {{ member }}
 allow-hotplug {{ member }}
 iface {{ member }} inet manual
    pre-up teamdctl {{ pc }} port add {{ member }} || true
-    post-up ifconfig {{ member }} up
+    post-up ip link show {{ pc }} && ifconfig {{ member }} up


you said that teamdctl port add will add the member while bring up the member, then why post-up is neccessary?

when we do ifdown/ifup after the interfaces become part of the LAG, we will need this.

lguohan · 2017-04-05T23:13:12Z

maybe below is more clear:

Do not bring up LAG member port when LAG is not created. This is because the LAG member port must be in DOWN state when joining to a LAG due to teamd limitation. Therefore, you cannot bring up a member port first and then join the port to a LAG.

Can you add this to the commit comment?

lguohan

can you modify the the commit message based on the feedback.

stcheng · 2017-04-05T23:22:32Z

@lguohan commit message is updated.

[lua]: use not to check whether the field exists (sonic-net#492) [PFCWD]: Periodically poll WD counters (sonic-net#473) [teamsyncd]: Add team_ifindex2ifname return value check (sonic-net#500) [qos]: fix SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH value mismatch bug (sonic-net#495) [copporch]: Add SAI_HOSTIF_TRAP_TYPE_UDLD (sonic-net#480) Signed-off-by: Shu0T1an ChenG <[email protected]>

[lua]: use not to check whether the field exists (#492) [PFCWD]: Periodically poll WD counters (#473) [teamsyncd]: Add team_ifindex2ifname return value check (#500) [qos]: fix SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH value mismatch bug (#495) [copporch]: Add SAI_HOSTIF_TRAP_TYPE_UDLD (#480) Signed-off-by: Shu0T1an ChenG <[email protected]>

swss: [vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (sonic-net#896) [aclorch]: Allow DTEL drop actions in DTEL flow watchlist (sonic-net#915) Fix typo in orchagent_restart_check from fasle to false. (sonic-net#923) [sonic-swss]: Fix for FPM accept call failure in ARM arch (sonic-net#925) Add retryCount option for orchagent_restart_check program. (sonic-net#833) [vlan] Add pytest cases to validate nonexistent vlan behavior. (sonic-net#874) [intfsorch] Wait for interface prior to prefix (sonic-net#796) Set timer only when interval changes. Not in each firing of the timer. (sonic-net#945) [test]: Fix set interface in configuration database (sonic-net#956) [copporch]: Fix polymorphic type error (sonic-net#946) [AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (sonic-net#952) [MirrorOrch]: Init the next hop ip with 0 instead of default constructor (sonic-net#953) [portsorch]: Add reference count of port (sonic-net#962) [mock_test]: Move mock tests into a separate folder to separate them from vs tests (sonic-net#950) remove crm acl_counters when acl_table removed (sonic-net#918) [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966) [policerorch]: Fix return code comparison error (sonic-net#968) [gitignore]: Add swss-dbg related files (sonic-net#967) [vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (sonic-net#934) [vxlanorch]: Add extra info into NOTICE logs (sonic-net#891) [test]: Add a neighbor entry with BCAST MAC and verify its ignored (sonic-net#955) [copporch]: Fix copporch in DEL command (sonic-net#972) [orchagent]: Fix crash during orchagent process exit (sonic-net#974) [vnetorch]: Fix VNET orchagents order for warm-reboot flow (sonic-net#958) [test]: Skip unstable test test_vnet_orch_1 (sonic-net#976) [intfsorch]: Fix rif flex counter removal error (sonic-net#975) Update tests README.md file [aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#978) [test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (sonic-net#981) [teamsyncd]: Add information for LAG membership changes (sonic-net#982) common: Add an assert to logger, which will log a message and abort. (sonic-net#286) [test]: Add IpAddress::isZero() unit test (sonic-net#289) do not abort when read timerfd return 0 and errno = 0 (sonic-net#291) Add BGP_STATE_TABLE in stateDB (sonic-net#273) [IpAddress]: add mcast scope on address and isFullMask method on prefix (sonic-net#285) Add ignore Wshadow pragma to json.hpp (sonic-net#292) [executor]: Fix Executor does not get correct priority saved in m_selectable (sonic-net#290) [schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#294) timerfd:read failure - Record in logs as error. (sonic-net#295) [schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#296) [schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (sonic-net#297) sairedis: ARM32 bit fixes, for 64bit printf format specifier (sonic-net#468) Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (sonic-net#472) Fixed config_syncd_barefoot function (sonic-net#474) [syncd_init_common.sh] fix fast reboot backwards compatibility (sonic-net#480) Add default bridge id for bridge port id of type PORT in virtual switch (sonic-net#473) Fix a bug in parsing kernel argument of fast-reboot (sonic-net#482) Add TimerWatchdog for monitoring long execution apis (sonic-net#469) Add specific comparison logic for tunnel map (sonic-net#475) [vslib] add ACL action capabilities support (sonic-net#481) Per buffer pool watermark polling mode (sonic-net#485) Add specific comparison logic for ACL counter (sonic-net#484) Process flex counters requests in separate thread (sonic-net#483) Make sairedis/syncd synchronous (sonic-net#476) Fixed conditional operator. (sonic-net#487) Signed-off-by: Shu0T1an ChenG <[email protected]>

swss: [vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (#896) [aclorch]: Allow DTEL drop actions in DTEL flow watchlist (#915) Fix typo in orchagent_restart_check from fasle to false. (#923) [sonic-swss]: Fix for FPM accept call failure in ARM arch (#925) Add retryCount option for orchagent_restart_check program. (#833) [vlan] Add pytest cases to validate nonexistent vlan behavior. (#874) [intfsorch] Wait for interface prior to prefix (#796) Set timer only when interval changes. Not in each firing of the timer. (#945) [test]: Fix set interface in configuration database (#956) [copporch]: Fix polymorphic type error (#946) [AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (#952) [MirrorOrch]: Init the next hop ip with 0 instead of default constructor (#953) [portsorch]: Add reference count of port (#962) [mock_test]: Move mock tests into a separate folder to separate them from vs tests (#950) remove crm acl_counters when acl_table removed (#918) [aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (#966) [policerorch]: Fix return code comparison error (#968) [gitignore]: Add swss-dbg related files (#967) [vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (#934) [vxlanorch]: Add extra info into NOTICE logs (#891) [test]: Add a neighbor entry with BCAST MAC and verify its ignored (#955) [copporch]: Fix copporch in DEL command (#972) [orchagent]: Fix crash during orchagent process exit (#974) [vnetorch]: Fix VNET orchagents order for warm-reboot flow (#958) [test]: Skip unstable test test_vnet_orch_1 (#976) [intfsorch]: Fix rif flex counter removal error (#975) Update tests README.md file [aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#978) [test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (#981) [teamsyncd]: Add information for LAG membership changes (#982) common: Add an assert to logger, which will log a message and abort. (#286) [test]: Add IpAddress::isZero() unit test (#289) do not abort when read timerfd return 0 and errno = 0 (#291) Add BGP_STATE_TABLE in stateDB (#273) [IpAddress]: add mcast scope on address and isFullMask method on prefix (#285) Add ignore Wshadow pragma to json.hpp (#292) [executor]: Fix Executor does not get correct priority saved in m_selectable (#290) [schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (#294) timerfd:read failure - Record in logs as error. (#295) [schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#296) [schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (#297) sairedis: ARM32 bit fixes, for 64bit printf format specifier (#468) Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (#472) Fixed config_syncd_barefoot function (#474) [syncd_init_common.sh] fix fast reboot backwards compatibility (#480) Add default bridge id for bridge port id of type PORT in virtual switch (#473) Fix a bug in parsing kernel argument of fast-reboot (#482) Add TimerWatchdog for monitoring long execution apis (#469) Add specific comparison logic for tunnel map (#475) [vslib] add ACL action capabilities support (#481) Per buffer pool watermark polling mode (#485) Add specific comparison logic for ACL counter (#484) Process flex counters requests in separate thread (#483) Make sairedis/syncd synchronous (#476) Fixed conditional operator. (#487) Signed-off-by: Shu0T1an ChenG <[email protected]>

Signed-off-by: Shu0T1an ChenG <[email protected]>

…-net#480) * [syncd_init_common.sh] fix fast reboot backwards compatibility We should handle both cases for backward-compatible with 201803: - fast-reboot - SONIC_BOOT_TYPE=fast-reboot * handle review comments

Includes commits ``` f3e1085 2021-04-22 | [swig] fix ConfigDBConnector.db_name (#483) [Qi Luo] 0e2f1c0 2021-04-21 | [swig] Implement SonicV2Connector.hmset() (#480) [Qi Luo] d18ce28 2021-04-21 | [swss-common] Add MUX Metrics Table (#482) [Tamer Ahmed] 2e5a194 2021-04-20 | Support for in-band-mgmt via management VRF (#479) [Venkatesan Mahalingam] 3e5529f 2021-04-19 | [swig] Implement TableEntryPoppable.pops() (#478) [Qi Luo] 4a3903b 2021-04-19 | Support for in-band-mgmt via management VRF. (#476) [Venkatesan Mahalingam] fc2c734 2021-04-19 | [swig] allow threads (#477) [Qi Luo] ```

Includes commits ``` f3e1085 2021-04-22 | [swig] fix ConfigDBConnector.db_name (sonic-net#483) [Qi Luo] 0e2f1c0 2021-04-21 | [swig] Implement SonicV2Connector.hmset() (sonic-net#480) [Qi Luo] d18ce28 2021-04-21 | [swss-common] Add MUX Metrics Table (sonic-net#482) [Tamer Ahmed] 2e5a194 2021-04-20 | Support for in-band-mgmt via management VRF (sonic-net#479) [Venkatesan Mahalingam] 3e5529f 2021-04-19 | [swig] Implement TableEntryPoppable.pops() (sonic-net#478) [Qi Luo] 4a3903b 2021-04-19 | Support for in-band-mgmt via management VRF. (sonic-net#476) [Venkatesan Mahalingam] fc2c734 2021-04-19 | [swig] allow threads (sonic-net#477) [Qi Luo] ```

Includes below commits ``` bf8c832 2021-07-22 | Fix DBInterface blocking operations (#505) (HEAD -> 202012, origin/202012) [Qi Luo] 0e9385f 2021-04-21 | [swig] Implement SonicV2Connector.hmset() (#480) [Qi Luo] 76be49f 2021-07-25 | Modify the hardcode separator ":" to variable. (#473) [PJHsieh] 142ae3c 2021-06-23 | Fix config prompt question issue (#500) [xumia] e7bebe1 2021-06-14 | Fix repo reference issue (#487) [xumia] ```

Includes commits ``` f3e1085 2021-04-22 | [swig] fix ConfigDBConnector.db_name (sonic-net#483) [Qi Luo] 0e2f1c0 2021-04-21 | [swig] Implement SonicV2Connector.hmset() (sonic-net#480) [Qi Luo] d18ce28 2021-04-21 | [swss-common] Add MUX Metrics Table (sonic-net#482) [Tamer Ahmed] 2e5a194 2021-04-20 | Support for in-band-mgmt via management VRF (sonic-net#479) [Venkatesan Mahalingam] 3e5529f 2021-04-19 | [swig] Implement TableEntryPoppable.pops() (sonic-net#478) [Qi Luo] 4a3903b 2021-04-19 | Support for in-band-mgmt via management VRF. (sonic-net#476) [Venkatesan Mahalingam] fc2c734 2021-04-19 | [swig] allow threads (sonic-net#477) [Qi Luo] ```

…D automatically (#18976) #### Why I did it src/sonic-platform-daemons ``` * 88bf8ec - (HEAD -> master, origin/master, origin/HEAD) [chassis][midplane] Modify the chassisd to log expected/unexpected midplane connectivity messages (#480) (34 hours ago) [Marty Y. Lok] ``` #### How I did it #### How to verify it #### Description for the changelog

[interfaces]: Do not bring up LAG members when LAG is not up

cc93d19

- Without this fix, the LAG members will be brought up. Due to the current design of teamd, interfaces cannot join teamd when they are up. Signed-off-by: Shuotian Cheng <[email protected]>

stcheng requested a review from lguohan April 5, 2017 21:16

stcheng self-assigned this Apr 5, 2017

lguohan reviewed Apr 5, 2017

View reviewed changes

lguohan approved these changes Apr 5, 2017

View reviewed changes

stcheng merged commit eef859b into sonic-net:master Apr 5, 2017

stcheng deleted the interfaces branch April 5, 2017 23:22

stcheng mentioned this pull request May 11, 2018

[swss]: Update sonic-swss submodule #1699

Merged

stcheng mentioned this pull request Jul 19, 2019

[submodule]: Update swss related submodules #3190

Merged

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

[copporch]: Add SAI_HOSTIF_TRAP_TYPE_UDLD (sonic-net#480)

0246df7

Signed-off-by: Shu0T1an ChenG <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[interfaces]: Do not bring up LAG members when LAG is not up #480

[interfaces]: Do not bring up LAG members when LAG is not up #480

stcheng commented Apr 5, 2017

lguohan Apr 5, 2017

stcheng Apr 5, 2017

lguohan commented Apr 5, 2017 •

edited

Loading

lguohan left a comment

stcheng commented Apr 5, 2017

[interfaces]: Do not bring up LAG members when LAG is not up #480

[interfaces]: Do not bring up LAG members when LAG is not up #480

Conversation

stcheng commented Apr 5, 2017

lguohan Apr 5, 2017

Choose a reason for hiding this comment

stcheng Apr 5, 2017

Choose a reason for hiding this comment

lguohan commented Apr 5, 2017 • edited Loading

lguohan left a comment

Choose a reason for hiding this comment

stcheng commented Apr 5, 2017

lguohan commented Apr 5, 2017 •

edited

Loading