Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance sonic-py-swsssdk pointer #4496

Merged
merged 1 commit into from
May 13, 2020

Conversation

judyjoseph
Copy link
Contributor

@judyjoseph judyjoseph commented Apr 29, 2020

- Why I did it
Advance sonic-py-swsssdk submodule to latest.

03748ce [MultiDB] add sonic-db-cli SAVE/FLUSHALL option (#69)
f2a7598 [doc]: Update README.md (#70)
581add1 [Multiasic]: Add calculation of interface index for backplane interfaces (#68)

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented May 1, 2020

retest vs please

@lguohan
Copy link
Collaborator

lguohan commented May 1, 2020

retest vsimage please

@judyjoseph
Copy link
Contributor Author

Please don't merge this PR now. The current sonic-py-swsssdk and sonic-snmpagent is already advanced throught this PR #4421.

I am keeping this as a place holder to advance the pointer again after this PR sonic-net/sonic-py-swsssdk#68, is merged in.

@lguohan
Copy link
Collaborator

lguohan commented May 5, 2020

do we still this pr?

@judyjoseph
Copy link
Contributor Author

do we still this pr?

If you could review this PR sonic-net/sonic-py-swsssdk#68, and approve if ok. Will update sonic-py-swsssdk in master branch using this PR.

@lguohan
Copy link
Collaborator

lguohan commented May 5, 2020

sonic-net/sonic-py-swsssdk#68 is merged

@dzhangalibaba
Copy link
Collaborator

dzhangalibaba commented May 5, 2020

could you help advance one more commit in sonic-py-swsssdk for the PING/SAVE/FLUSHALL changes in this PR as well so I don't need to open a duplicated one.

[MultiDB] add sonic-db-cli SAVE/FLUSHALL option (#69)

@judyjoseph

@judyjoseph
Copy link
Contributor Author

retest this please

@qiluo-msft
Copy link
Collaborator

@judyjoseph there is conflict, could you help fix?

@judyjoseph judyjoseph force-pushed the swsssdk-py-advance branch from 5ade330 to c6b005b Compare May 6, 2020 23:02
@judyjoseph
Copy link
Contributor Author

retest broadcom please

1 similar comment
@dzhangalibaba
Copy link
Collaborator

retest broadcom please

@judyjoseph judyjoseph requested a review from qiluo-msft May 12, 2020 18:14
@judyjoseph judyjoseph merged commit 60a0471 into sonic-net:master May 13, 2020
@judyjoseph judyjoseph deleted the swsssdk-py-advance branch May 13, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants