Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added QFX5210 readme for build and install #4211

Merged
merged 4 commits into from
Mar 20, 2020

Conversation

ashishb-juniper
Copy link
Contributor

Documentation for installing SONiC on Juniper QFX5210 platform

Signed-off-by: Ciju Rajan K [email protected]
Signed-off-by: Ashish Bhensdadia [email protected]

Signed-off-by: Ciju Rajan K <[email protected]>
Signed-off-by: Ashish Bhensdadia <[email protected]>
@msftclas
Copy link

msftclas commented Mar 2, 2020

CLA assistant check
All CLA requirements met.

@ashishb-juniper
Copy link
Contributor Author

@lguohan @jleveque

Please take a look pull request.

-Ashish

Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format all commands and command output in code blocks (surround by three backticks) for readability.

@ashishb-juniper
Copy link
Contributor Author

@jleveque

incorporated format related comments. Please take a look pull request.

Thanks
Ashish

@ashishb-juniper
Copy link
Contributor Author

@jleveque

Can you please take a look?

-Ashish

@ashishb-juniper
Copy link
Contributor Author

@jleveque deleted extra blank lines.

@ashishb-juniper
Copy link
Contributor Author

@jleveque
Why it is not merged with master. What can be done from my side. is vs and vsimage cause a issue?

@jleveque
Copy link
Contributor

Retest this please

@jleveque
Copy link
Contributor

@ashishb-juniper: Yes, the vs and vsimage check build failures were preventing this from being merged. I just kicked off a fresh set of tests with the comment above. Let's wait to see the results.

@ashishb-juniper
Copy link
Contributor Author

@jleveque : now only vsimage. Is there any way we can skip the vsimage test cases?

@lguohan lguohan merged commit f88dffe into sonic-net:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants