-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[init_cfg.json] Add new FEATURE and CONTAINER_FEATURE tables #4137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yong Zhao <[email protected]>
Signed-off-by: Yong Zhao <[email protected]>
jleveque
suggested changes
Feb 10, 2020
CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]>
As part of this PR, can you please also add the new "FEATURE" table above the "CONTAINER_FEATURE" table?
|
@jleveque Sure, will update it. |
Signed-off-by: Yong Zhao <[email protected]>
jleveque
suggested changes
Feb 11, 2020
alphabetical order. Signed-off-by: Yong Zhao <[email protected]>
prsunny
reviewed
Feb 11, 2020
jleveque
suggested changes
Feb 11, 2020
jleveque
changed the title
[init_cfg.json] Add a new table CONTAINER_FEATURE
[init_cfg.json] Add new FEATURE and CONTAINER_FEATURE tables
Feb 11, 2020
Signed-off-by: Yong Zhao <[email protected]>
jleveque
approved these changes
Feb 11, 2020
prsunny
approved these changes
Feb 11, 2020
abdosi
pushed a commit
that referenced
this pull request
Feb 14, 2020
* [init_cfg.json] Add a new table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Update the content of table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Use the template to generate the table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Add a new table FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Change the order of container names according to alphabetical order. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Change the dhcp_relay container name and add rest-api. Signed-off-by: Yong Zhao <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Feb 26, 2020
…et#4137) * [init_cfg.json] Add a new table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Update the content of table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Use the template to generate the table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Add a new table FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Change the order of container names according to alphabetical order. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Change the dhcp_relay container name and add rest-api. Signed-off-by: Yong Zhao <[email protected]> Conflicts: files/build_templates/init_cfg.json.j2
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
…et#4137) * [init_cfg.json] Add a new table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Update the content of table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Use the template to generate the table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Add a new table FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Change the order of container names according to alphabetical order. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Change the dhcp_relay container name and add rest-api. Signed-off-by: Yong Zhao <[email protected]>
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
…et#4137) * [init_cfg.json] Add a new table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Update the content of table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Use the template to generate the table CONTAINER_FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Add a new table FEATURE. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Change the order of container names according to alphabetical order. Signed-off-by: Yong Zhao <[email protected]> * [init_cfg.json] Change the dhcp_relay container name and add rest-api. Signed-off-by: Yong Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yong Zhao [email protected]
- What I did
I created a table named CONTAINER_FEATURE in which the auto-restart feature of each container is
currently set to be "enabled". This table will be used to initialize the Config_DB.
- How I did it
- How to verify it