-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update arp_update to refresh neighbor entries from APP_DB #4125
Conversation
retest vsimage please |
retest vs please |
retest vsimage please |
retest vs please |
In general, if we are facing some scale issue already (e,g, > 1K neighbors), we should change this arp_update scripts to scapy based (like the one here: https://github.com/Azure/sonic-swss/blob/11fe6b520693c31c5e1398274035e103d2977a31/neighsyncd/restore_neighbors.py), it is way too slow here. like arping could take ~0.1 second. ping had 0.2 second timeout. we can easily hit 100s seconds to probe the devices, and totally time could be way more than 300 seconds. In the script should should check the time clock and the sleep should exclude the time spent on the processing. (if already more than 300s, no sleep). |
Approving this PR with some comments: |
- What I did
arp_update to refresh neighbor entries from APP_DB
- How I did it
Modified arp_update script
- How to verify it
syslogs
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)