[bgpcfgd] bgp peer is not added successfully sometimes #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest vs please |
| @@ -283,6 +283,8 @@ class BGPPeerMgr(Manager): | |||
| } | |||
|
|
|||
| def set_handler(self, key, data): | |||
| if not self.directory.path_exist("meta", "localhost/bgp_asn"): | |||
| return False | |||
There was a problem hiding this comment.
I think that the change must be following:
def on_deps_change(self):
+ if not self.directory.available_deps(self.deps):
+ return
new_queue = []
for key, data in self.set_queue:
res = self.set_handler(key, data)
I'll have it on my new PR I'm currently working.
There was a problem hiding this comment.
I'd suggest to close your PR and merge #4027
OK, thanks!
|
I'd suggest to close your PR and merge #4027 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix the issue #3862 (sonic-net/sonic-utilities#782).
- How I did it
Checking meta existance first in peer handler, if not then return false.
- How to verify it
Test many times by rebooting with bgp configs(with vrf or not).
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)