Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bgpcfgd]: Avoid crashing bgpcfgd when render of bgpd.peer.conf.j2 has issues #3668

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

pavel-shirshov
Copy link
Contributor

- What I did
Fix a possibility to crash bgpcfgd by incorrect j2 template
- How I did it
Add try catch block
- How to verify it

  1. Delete existing bgp peer: DEL BGP_PEER|10.0.0.1
  2. Change properties for the deleted peer: hset BGP_PEER|10.0.0.1 admin up

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@pavel-shirshov
Copy link
Contributor Author

retest vs please

@lguohan lguohan merged commit 3a78709 into sonic-net:master Oct 29, 2019
mssonicbld added a commit that referenced this pull request Dec 11, 2024
…atically (#21128)

#### Why I did it
src/sonic-utilities
```
* d5cbe464 - (HEAD -> master, origin/master, origin/HEAD) [GCU] Add data acl table and rule check (#3668) (3 minutes ago) [jingwenxie]
```
#### How I did it
#### How to verify it
#### Description for the changelog
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
…atically (sonic-net#21128)

#### Why I did it
src/sonic-utilities
```
* d5cbe464 - (HEAD -> master, origin/master, origin/HEAD) [GCU] Add data acl table and rule check (sonic-net#3668) (3 minutes ago) [jingwenxie]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants