[gobgp]: do not install docker-fpm-gobgp into one image #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcheng
approved these changes
Mar 3, 2017
stcheng
reviewed
Mar 3, 2017
| @@ -4,7 +4,8 @@ include $(PLATFORM_PATH)/docker-orchagent-cavm.mk | |||
| include $(PLATFORM_PATH)/cavm_platform_modules.mk | |||
| include $(PLATFORM_PATH)/one-image.mk | |||
|
|
|||
| SONIC_ALL += $(SONIC_ONE_IMAGE) | |||
| SONIC_ALL += $(SONIC_ONE_IMAGE) \ | |||
| $(DOCKER_FPM_GOBGP) | |||
There was a problem hiding this comment.
put the docker_fpm_gobgp into platform/generic/rules.mk?
There was a problem hiding this comment.
it requires swss, so cannot be put into generic
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Nov 1, 2018
swss: * 863b69c 2018-11-01 | [teamsyncd]: Fix bug when removing selectable in select function (sonic-net#665) (HEAD, origin/master, origin/HEAD) [Shuotian Cheng] * 2c83b68 2018-10-31 | Warm reboot: bring up ports for whole system warm reboot (sonic-net#653) [Qi Luo] * d049d65 2018-10-31 | [vstest]: get subscribed objects from appdb and asicdb (sonic-net#664) [lguohan] * 057a329 2018-10-31 | [vstest]: change the redis mount point when --dvsname is provided. (sonic-net#663) [lguohan] * 34e157e 2018-10-31 | [VS]: fix swss warm restart test (sonic-net#662) [Jipan Yang] sairedis: * c612c5e 2018-11-01 | Add specific comparison logic for more objects (sonic-net#360) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik] * a6b709a 2018-10-31 | [syncd] re-establish notifications after warm boot (sonic-net#368) [Ying Xie] * d655d20 2018-10-29 | [syncd] partial warm recovery support (sonic-net#352) [Ying Xie] * 4d9aa18 2018-10-29 | Add missing object types to virtual switch (sonic-net#364) [Kamil Cudnik] * 1fdaf47 2018-10-29 | Add VS support for setting stats via redis DB channel (sonic-net#366) [Kamil Cudnik] Signed-off-by: Guohan Lu <[email protected]>
lguohan
added a commit
that referenced
this pull request
Nov 1, 2018
swss: * 863b69c 2018-11-01 | [teamsyncd]: Fix bug when removing selectable in select function (#665) (HEAD, origin/master, origin/HEAD) [Shuotian Cheng] * 2c83b68 2018-10-31 | Warm reboot: bring up ports for whole system warm reboot (#653) [Qi Luo] * d049d65 2018-10-31 | [vstest]: get subscribed objects from appdb and asicdb (#664) [lguohan] * 057a329 2018-10-31 | [vstest]: change the redis mount point when --dvsname is provided. (#663) [lguohan] * 34e157e 2018-10-31 | [VS]: fix swss warm restart test (#662) [Jipan Yang] sairedis: * c612c5e 2018-11-01 | Add specific comparison logic for more objects (#360) (HEAD, origin/master, origin/HEAD) [Kamil Cudnik] * a6b709a 2018-10-31 | [syncd] re-establish notifications after warm boot (#368) [Ying Xie] * d655d20 2018-10-29 | [syncd] partial warm recovery support (#352) [Ying Xie] * 4d9aa18 2018-10-29 | Add missing object types to virtual switch (#364) [Kamil Cudnik] * 1fdaf47 2018-10-29 | Add VS support for setting stats via redis DB channel (#366) [Kamil Cudnik] Signed-off-by: Guohan Lu <[email protected]>
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
This reverts commit 7a51a85.
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
…onic-net#366) This change is the first step of refactoring Orch class. The global variable gPortsOrch is removed from that orch.cpp file and this class no longer requires such external variable. The current solution is to move the global variable into each different places that need this variable. Later, a better design could be introduced to further remove all the global variables from the whole project. Signed-off-by: Shu0T1an ChenG <[email protected]>
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
* Add VS support for setting stats via redis DB channel * Remove SET description
mssonicbld
added a commit
that referenced
this pull request
Sep 20, 2023
… automatically (#16602) #### Why I did it src/sonic-platform-common ``` * 3d3bc1a - (HEAD -> master, origin/master, origin/HEAD) [Credo][Ycable] Fix for displaying 'N/A' firmware version when NIC endpoint is power off (#366) (2 hours ago) [Xinyu Lin] ``` #### How I did it #### How to verify it #### Description for the changelog
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
… automatically (sonic-net#16602) #### Why I did it src/sonic-platform-common ``` * 3d3bc1a - (HEAD -> master, origin/master, origin/HEAD) [Credo][Ycable] Fix for displaying 'N/A' firmware version when NIC endpoint is power off (sonic-net#366) (2 hours ago) [Xinyu Lin] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.