Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-fpm-frr] Filter out 'Dockerfile.j2' from the 'docker-fpm-frr' image #3507

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

wangshengjun
Copy link
Contributor

[docker-fpm-frr]:filter out the file of 'Dockerfile.j2' from the 'docker-fpm-frr' image.

Signed-off-by: wangshengjun [email protected]

- What I did
filter out the file of 'Dockerfile.j2' from the docker image.
- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this can also be accomplished by creating a .dockerignore file containing the line Dockerfile.j2 and leaving line 47 unmodified.

@wangshengjun
Copy link
Contributor Author

I believe this can also be accomplished by creating a .dockerignore file containing the line Dockerfile.j2 and leaving line 47 unmodified.

Thanks for your suggestion. I have already changed it, please take a review.

@jleveque
Copy link
Contributor

Retest vsimage please

@jleveque jleveque changed the title [docker-fpm-frr]:filter out the file of 'Dockerfile.j2' from the 'doc… [docker-fpm-frr] Filter out 'Dockerfile.j2' from the 'docker-fpm-frr' image Sep 26, 2019
@jleveque jleveque merged commit 59febed into sonic-net:master Sep 27, 2019
mssonicbld added a commit that referenced this pull request Sep 5, 2024
…atically (#20139)

#### Why I did it
src/sonic-utilities
```
* b530116b - (HEAD -> 202311, origin/202311) [202311] [Mellanox] Add CMIS Host Management Files to 'show techsupport' Dumps (#3507) (4 hours ago) [Tomer Shalvi]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants