[Mellanox] platform_reboot - sync & umount fs before power cycle #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Faryma <[email protected]>
lguohan
reviewed
Sep 11, 2019
| @@ -19,6 +19,14 @@ function ParseArguments() { | |||
| done | |||
| } | |||
|
|
|||
| function SafePwrCycle() { | |||
| sync ; sync | |||
| umount -fa > /dev/null 2&>1 | |||
There was a problem hiding this comment.
this looks like a generic commands for all that does the power cycle?
There was a problem hiding this comment.
Yes, Note that it's the platform reboot script, so this is only for Mellanox platforms.
liat-grozovik
approved these changes
Sep 16, 2019
lguohan
approved these changes
Sep 16, 2019
|
@mykolaf Can you create a separate PR for 201811 branch please? This change cannot be cherry-picked cleanly. Thanks! |
mykolaf
added a commit
to mykolaf/sonic-buildimage
that referenced
this pull request
Sep 18, 2019
…ic-net#3430) Signed-off-by: Mykola Faryma <[email protected]>
sujinmkang
pushed a commit
that referenced
this pull request
Sep 26, 2019
…) (#3476) Signed-off-by: Mykola Faryma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mykola Faryma [email protected]
We noticed that null characters sometimes appear in our logs after we started using power cycle to reboot.
This gets in the way of greping the logs.
- What I did
Made sure the filesystem is synced and unmounted before performing the power cycle.
- How I did it
- How to verify it
Perform multiple reboots, then
cat -A /var/log/syslog* | grep -A 15 rebooting | grep ^@
Check that no null characters are present
- Description for the changelog
Made sure the filesystem is synced and unmounted before performing the power cycle on Mellanox platforms.
- A picture of a cute animal (not mandatory but encouraged)