-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hash seed for SpineRouter type. #3390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be great to merge to 201811 branch too. |
retest broadcom please |
retest mellanox please |
stcheng
approved these changes
Aug 28, 2019
Signed-off-by: Zhenggen Xu <[email protected]>
deeb9bb
to
22713a5
Compare
stcheng
approved these changes
Aug 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
yxieca
pushed a commit
that referenced
this pull request
Aug 28, 2019
Signed-off-by: Zhenggen Xu <[email protected]>
wangshengjun
pushed a commit
to wangshengjun/sonic-buildimage
that referenced
this pull request
Nov 16, 2020
Signed-off-by: Zhenggen Xu <[email protected]>
mssonicbld
added a commit
that referenced
this pull request
Jul 6, 2024
…atically (#19419) #### Why I did it src/sonic-utilities ``` * fb2e5cda - (HEAD -> master, origin/master, origin/HEAD) Remove secret from golden_config_db.json and old_config files (#3390) (2 days ago) [Hua Liu] * 414cf3bb - [DPB]Fix return code in case of failure (#3389) (4 days ago) [Sudharsan Dhamal Gopalarathnam] * 06965df2 - Remove suppress-fib-pending CLI and make route_check.py check suppress-fib in BGP configuration (#3331) (5 days ago) [Stepan Blyshchak] * 3a8f0be0 - [Mellanox] Add support for ACS-4280 (#3368) (8 days ago) [Vivek] * 667a1509 - [pbh]: Fix show PBH counters when cache is partial (#3356) (8 days ago) [Nazarii Hnydyn] ``` #### How I did it #### How to verify it #### Description for the changelog
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…atically (sonic-net#19419) #### Why I did it src/sonic-utilities ``` * fb2e5cda - (HEAD -> master, origin/master, origin/HEAD) Remove secret from golden_config_db.json and old_config files (sonic-net#3390) (2 days ago) [Hua Liu] * 414cf3bb - [DPB]Fix return code in case of failure (sonic-net#3389) (4 days ago) [Sudharsan Dhamal Gopalarathnam] * 06965df2 - Remove suppress-fib-pending CLI and make route_check.py check suppress-fib in BGP configuration (sonic-net#3331) (5 days ago) [Stepan Blyshchak] * 3a8f0be0 - [Mellanox] Add support for ACS-4280 (sonic-net#3368) (8 days ago) [Vivek] * 667a1509 - [pbh]: Fix show PBH counters when cache is partial (sonic-net#3356) (8 days ago) [Nazarii Hnydyn] ``` #### How I did it #### How to verify it #### Description for the changelog
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
…atically (sonic-net#19419) #### Why I did it src/sonic-utilities ``` * fb2e5cda - (HEAD -> master, origin/master, origin/HEAD) Remove secret from golden_config_db.json and old_config files (sonic-net#3390) (2 days ago) [Hua Liu] * 414cf3bb - [DPB]Fix return code in case of failure (sonic-net#3389) (4 days ago) [Sudharsan Dhamal Gopalarathnam] * 06965df2 - Remove suppress-fib-pending CLI and make route_check.py check suppress-fib in BGP configuration (sonic-net#3331) (5 days ago) [Stepan Blyshchak] * 3a8f0be0 - [Mellanox] Add support for ACS-4280 (sonic-net#3368) (8 days ago) [Vivek] * 667a1509 - [pbh]: Fix show PBH counters when cache is partial (sonic-net#3356) (8 days ago) [Nazarii Hnydyn] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add hash seed for SpineRouter type.
Signed-off-by: Zhenggen Xu [email protected]
- What I did
Add hash seed for SpineRouter type.
- How I did it
change the switch.json.j2 file to check SpineRouter type and provide a different hash seed.
- How to verify it
Change config_db.json for the type:
"DEVICE_METADATA": {
"localhost": {
...
"type": "SpineRouter"
}
},
We can see the the file /etc/swss/config.d/switch.json in swss docker has below config:
[
{
"SWITCH_TABLE:switch": {
"ecmp_hash_seed": "15",
"lag_hash_seed": "15",
"fdb_aging_time": "600"
},
"OP": "SET"
}
]
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)