-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build]: use j2 template for sonic slave Dockerfile #3223
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate sonic slave Dockerfile based on j2 template Signed-off-by: Guohan Lu <[email protected]>
@antony-rheneus for review |
retest this please |
antony-rheneus
approved these changes
Jul 26, 2019
retest vsimage please |
retest vs please |
mssonicbld
added a commit
that referenced
this pull request
Sep 28, 2024
…lly (#20339) #### Why I did it src/sonic-swss ``` * 3c230d2b - (HEAD -> master, origin/master, origin/HEAD) [Orchagent] Add optional create_switch timeout parameter (#3258) (3 days ago) [Pavan Naregundi] * be3a15f6 - Update CODEOWNERS VNET and ACL Orch (#3296) (3 days ago) [siqbal1986] * 002cd256 - Close socket descriptor in checkPortIffUp. (#3263) (3 days ago) [mint570] * 69cf0872 - [orchagent]: Skip installing ACL counter when ACL mirror rule is inactive (#3223) (3 days ago) [fountzou] * 008f2865 - [crm][dash] Do not probe DASH resources on devices other than the DPU. (#3297) (3 days ago) [Oleksandr Ivantsiv] * 971dfc1a - Add support for PACKET_ACTION_COPY (#3288) (4 days ago) [Devesh Pathak] ``` #### How I did it #### How to verify it #### Description for the changelog
saksarav-nokia
pushed a commit
to saksarav-nokia/sonic-buildimage
that referenced
this pull request
Oct 9, 2024
…lly (sonic-net#20339) #### Why I did it src/sonic-swss ``` * 3c230d2b - (HEAD -> master, origin/master, origin/HEAD) [Orchagent] Add optional create_switch timeout parameter (sonic-net#3258) (3 days ago) [Pavan Naregundi] * be3a15f6 - Update CODEOWNERS VNET and ACL Orch (sonic-net#3296) (3 days ago) [siqbal1986] * 002cd256 - Close socket descriptor in checkPortIffUp. (sonic-net#3263) (3 days ago) [mint570] * 69cf0872 - [orchagent]: Skip installing ACL counter when ACL mirror rule is inactive (sonic-net#3223) (3 days ago) [fountzou] * 008f2865 - [crm][dash] Do not probe DASH resources on devices other than the DPU. (sonic-net#3297) (3 days ago) [Oleksandr Ivantsiv] * 971dfc1a - Add support for PACKET_ACTION_COPY (sonic-net#3288) (4 days ago) [Devesh Pathak] ``` #### How I did it #### How to verify it #### Description for the changelog
sschlafman
pushed a commit
to sschlafman/sonic-buildimage
that referenced
this pull request
Oct 15, 2024
…lly (sonic-net#20339) #### Why I did it src/sonic-swss ``` * 3c230d2b - (HEAD -> master, origin/master, origin/HEAD) [Orchagent] Add optional create_switch timeout parameter (sonic-net#3258) (3 days ago) [Pavan Naregundi] * be3a15f6 - Update CODEOWNERS VNET and ACL Orch (sonic-net#3296) (3 days ago) [siqbal1986] * 002cd256 - Close socket descriptor in checkPortIffUp. (sonic-net#3263) (3 days ago) [mint570] * 69cf0872 - [orchagent]: Skip installing ACL counter when ACL mirror rule is inactive (sonic-net#3223) (3 days ago) [fountzou] * 008f2865 - [crm][dash] Do not probe DASH resources on devices other than the DPU. (sonic-net#3297) (3 days ago) [Oleksandr Ivantsiv] * 971dfc1a - Add support for PACKET_ACTION_COPY (sonic-net#3288) (4 days ago) [Devesh Pathak] ``` #### How I did it #### How to verify it #### Description for the changelog
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
…lly (sonic-net#20339) #### Why I did it src/sonic-swss ``` * 3c230d2b - (HEAD -> master, origin/master, origin/HEAD) [Orchagent] Add optional create_switch timeout parameter (sonic-net#3258) (3 days ago) [Pavan Naregundi] * be3a15f6 - Update CODEOWNERS VNET and ACL Orch (sonic-net#3296) (3 days ago) [siqbal1986] * 002cd256 - Close socket descriptor in checkPortIffUp. (sonic-net#3263) (3 days ago) [mint570] * 69cf0872 - [orchagent]: Skip installing ACL counter when ACL mirror rule is inactive (sonic-net#3223) (3 days ago) [fountzou] * 008f2865 - [crm][dash] Do not probe DASH resources on devices other than the DPU. (sonic-net#3297) (3 days ago) [Oleksandr Ivantsiv] * 971dfc1a - Add support for PACKET_ACTION_COPY (sonic-net#3288) (4 days ago) [Devesh Pathak] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Dec 1, 2024
…lly (#20965) #### Why I did it src/sonic-swss ``` * fbe52b16 - (HEAD -> 202405, origin/202405) Add FEC correctable bit error count to ports_stat_ids (#3291) (4 hours ago) [Prince George] * 5a608ae1 - [Chassis][LAG_ID] Address the same lagid been used in two different LCs issue (#3303) (4 hours ago) [Marty Y. Lok] * 09d274c9 - [orchagent]: Skip installing ACL counter when ACL mirror rule is inactive (#3223) (3 days ago) [fountzou] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate sonic slave Dockerfile based on j2 template
Signed-off-by: Guohan Lu [email protected]
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)