-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ifupdown2 to version 1.2.8 #3180
Merged
lguohan
merged 2 commits into
sonic-net:master
from
rajendra-dendukuri:ifupdown2_upgrade
Jul 20, 2019
Merged
Upgrade ifupdown2 to version 1.2.8 #3180
lguohan
merged 2 commits into
sonic-net:master
from
rajendra-dendukuri:ifupdown2_upgrade
Jul 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required by ZTP to support ZTP over IPv6 transport Signed-off-by: Rajendra Dendukuri <[email protected]>
lguohan
approved these changes
Jul 18, 2019
pavel-shirshov
suggested changes
Jul 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comments
Remove git statements as no patches are being applied. Signed-off-by: Rajendra Dendukuri <[email protected]>
stcheng
approved these changes
Jul 19, 2019
pavel-shirshov
approved these changes
Jul 19, 2019
retest mellanox please |
retest vsimage please |
1 similar comment
retest vsimage please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Instead of using ifupdown2 package from Debian stretch repository, source compiled and installed lates
version of ifupdown2. The latest version is required to support ZTP over IPv6 transport in a stable and
quick manner.
- How I did it
Created a new rules/ifupdown2.mk file and compiled ifupdown2 as a SONIC_MAKE_DEBS.
Modified slave.mk to have the ifupdown2 as a dependency to create sonic installer image.
Modified "files/build_templates/sonic_debian_extension.j2" to install source compiled ifupdown2 deb file and its dependencies.
- How to verify it
Load an image with these changes and check ifupdown2 version using the command dpkg -l ifupdown2
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-============-============-=================================
ii ifupdown2 1.2.8-1 all Network Interface Management tool
Verified that "systemctl restart interfaces-config" also works.
Verified if eth0 IP is picked up via DHCP without any issues.
- Description for the changelog
Upgrade ifupdown2 to version 1.2.8
- A picture of a cute animal (not mandatory but encouraged)