Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing dhcp- turn- off option from initrd #2555

Merged
merged 2 commits into from
Apr 2, 2019

Conversation

paavaanan
Copy link
Contributor

- What I did

  • This option kick-in only at NOS-to-SONiC migration.
  • Removing "dhcp-turn-off" option from initrd it is no longer necessary as it is already taken care off.

- How I did it

  • Avoid copying the required files in FILESYSTEM_ROOT

- How to verify it

  • No dhcp search shoud happen at boot-time.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@@ -151,8 +151,8 @@ sudo chmod +x $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-bottom/union-mou
sudo cp files/initramfs-tools/varlog $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-bottom/varlog
sudo chmod +x $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-bottom/varlog
# Management interface (eth0) dhcp can be optionally turned off (during a migration from another NOS to SONiC)
sudo cp files/initramfs-tools/mgmt-intf-dhcp $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-bottom/mgmt-intf-dhcp
sudo chmod +x $FILESYSTEM_ROOT/etc/initramfs-tools/scripts/init-bottom/mgmt-intf-dhcp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also remove the file that is no longer needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

@stcheng stcheng requested a review from lguohan March 26, 2019 22:28
@yxieca yxieca merged commit b56124b into sonic-net:master Apr 2, 2019
yxieca pushed a commit that referenced this pull request Apr 4, 2019
* removing dhcp changes from initrd

* removing mgmt-intf-dhcp file
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
* removing dhcp changes from initrd

* removing mgmt-intf-dhcp file
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
* removing dhcp changes from initrd

* removing mgmt-intf-dhcp file
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
* removing dhcp changes from initrd

* removing mgmt-intf-dhcp file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants