-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[201803] [radvd] Build radvd from source; Patch so as not to treat out-of-range MTU as an error #2552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, when we make a temporary change of this kind, more as a workaround, it will be nice to add a comment on why. This would help a new dev looking at this code in future. Even for us, when we revisit after a while, it will help us recall quickly.
suggest to break into two PR, one for mtu fix and another for wait_for_intf.sh.j2. In this case, we can easily decide which one to cherry-pick. I also agree with renuka that we add why in the patch itself. sometimes, we are not able to look back at the commit message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as comments
|
swss: * 6902a98 2022-12-13 | [muxorch] Skip programming SoC IP kernel tunnel route (sonic-net#2557) (HEAD -> 202205) [Longxiang Lyu] * 8a86404 2022-12-07 | [portinit] Do not call GET on SAI_PORT_ATTR_SPEED when AUTONEG is enabled (sonic-net#2484) [Vaibhav Hemant Dixit] * d16f51d 2022-12-07 | Revert "sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (sonic-net#2552)" (github/202205) [Ying Xie] * abc6a81 2022-12-05 | sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (sonic-net#2552) [Sambath Kumar Balasubramanian] sonic-utilities: * 2c29fde 2022-12-13 | [202205][route_check]: Ignore ASIC only SOC IPs (cherry-picking sonic-net#2548) (sonic-net#2552) (HEAD -> 202205, github/202205) [Ying Xie] * aaa8d25 2022-12-13 | [202205][generate_dump]: Enhance show techsupport for cisco-8000 platform (sonic-net#2533) [Geert Vlaemynck] * 25d581e 2022-12-13 | [202205][show]Fix show route return code on error (sonic-net#2547) [Sudharsan Dhamal Gopalarathnam] * da870fc 2022-11-17 | [azure-pipelines] update azp from buster to bullseye (sonic-net#2455) [Mai Bui] Signed-off-by: Ying Xie <[email protected]>
swss: * 6902a98 2022-12-13 | [muxorch] Skip programming SoC IP kernel tunnel route (#2557) (HEAD -> 202205) [Longxiang Lyu] * 8a86404 2022-12-07 | [portinit] Do not call GET on SAI_PORT_ATTR_SPEED when AUTONEG is enabled (#2484) [Vaibhav Hemant Dixit] * d16f51d 2022-12-07 | Revert "sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (#2552)" (github/202205) [Ying Xie] * abc6a81 2022-12-05 | sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (#2552) [Sambath Kumar Balasubramanian] sonic-utilities: * 2c29fde 2022-12-13 | [202205][route_check]: Ignore ASIC only SOC IPs (cherry-picking #2548) (#2552) (HEAD -> 202205, github/202205) [Ying Xie] * aaa8d25 2022-12-13 | [202205][generate_dump]: Enhance show techsupport for cisco-8000 platform (#2533) [Geert Vlaemynck] * 25d581e 2022-12-13 | [202205][show]Fix show route return code on error (#2547) [Sudharsan Dhamal Gopalarathnam] * da870fc 2022-11-17 | [azure-pipelines] update azp from buster to bullseye (#2455) [Mai Bui] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
6185324 dereg acl-rule counters during acl-table del (sonic-net#2574) b865352 Align watermark flow with port configuration (sonic-net#2525) f2d2fb3 L3 / L3 V6 Egress ACL table creation failure (sonic-net#2561) 577f696 [muxorch] Skip programming ACL for standby `active-active` ports (sonic-net#2569) 242ee11 [muxorch] Skip programming SoC IP kernel tunnel route (sonic-net#2557) 6695113 [gearbox] Support setting tx taps on gearbox ports (sonic-net#2158) 872f7bf [portinit] Do not call GET on SAI_PORT_ATTR_SPEED when AUTONEG is enabled (sonic-net#2484) 6afefe1 [vstest][virtual chassis] Removed dvs.runcmd using click commands (sonic-net#2214) b8521cc [p4orch]: PINS Extension tables support (sonic-net#2506) d0419dc sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (sonic-net#2552) bd652a0 [muxorch] Adding case for maintaining current state (sonic-net#2280) 6b6dda6 [Centec]for support mclag of centec to configure port isolate-group sonic-net#2529 ec507a4 [ACL] Support ACTION_COUNTER action in custom ACL table type (sonic-net#2550) 1a74604 Use github code scanning instead of LGTM (sonic-net#2546) bc3c894 [dual-tor] add missing SAI attribte in order to create IPNIP tunnel (sonic-net#2503) dca78d8 (origin/202211) [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. (sonic-net#2521) Signed-off-by: Vivek Reddy Karri <[email protected]>
6185324 dereg acl-rule counters during acl-table del (#2574) b865352 Align watermark flow with port configuration (#2525) f2d2fb3 L3 / L3 V6 Egress ACL table creation failure (#2561) 577f696 [muxorch] Skip programming ACL for standby `active-active` ports (#2569) 242ee11 [muxorch] Skip programming SoC IP kernel tunnel route (#2557) 6695113 [gearbox] Support setting tx taps on gearbox ports (#2158) 872f7bf [portinit] Do not call GET on SAI_PORT_ATTR_SPEED when AUTONEG is enabled (#2484) 6afefe1 [vstest][virtual chassis] Removed dvs.runcmd using click commands (#2214) b8521cc [p4orch]: PINS Extension tables support (#2506) d0419dc sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (#2552) bd652a0 [muxorch] Adding case for maintaining current state (#2280) 6b6dda6 [Centec]for support mclag of centec to configure port isolate-group #2529 ec507a4 [ACL] Support ACTION_COUNTER action in custom ACL table type (#2550) 1a74604 Use github code scanning instead of LGTM (#2546) bc3c894 [dual-tor] add missing SAI attribte in order to create IPNIP tunnel (#2503) dca78d8 (origin/202211) [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. (#2521)
…atform-common][py-swsssdk] advance submodule head linkmgrd: * bf75a93 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#157) (HEAD -> 202205, github/202205) [Liu Shilong] utilities: * c1fa31d 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#2530) (HEAD -> 202205) [Liu Shilong] * 9990208 2022-05-19 | Add sonic-delayed.target to Application Extension .timer file generator (sonic-net#2176) [noaOrMlnx] swss: * 7b3170a 2023-01-05 | Revert "sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (sonic-net#2552)" (HEAD -> 202205) [Ying Xie] * 4897e93 2023-01-05 | Revert "[bufferorch] : Support for buffer profiles for VoQ on chassis (sonic-net#2465)" (HEAD -> 202205, github/202205) [Ying Xie] * bbccc68 2023-01-04 | [vstest] Only collect stdout of orchagent_restart_check in vstest (sonic-net#2597) (HEAD -> 202205, github/202205) [bingwang-ms] * f7a7c05 2023-01-04 | Avoid aborting orchagent when setting TUNNEL attributes (sonic-net#2591) [Stephen Sun] * 84064fa 2022-12-20 | Fixed a bug causing error state of same configuration is applied twice. (sonic-net#2580) [siqbal1986] * 4851bef 2022-12-20 | Only collect stdout of orchagent_restart_check in vstest (sonic-net#2578) [bingwang-ms] * 2904d95 2022-12-05 | sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (sonic-net#2552) [Sambath Kumar Balasubramanian] * ac84e41 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#2546) [Liu Shilong] * 502bd69 2022-12-20 | Fix `test_vlan.py` (sonic-net#2541) [Longxiang Lyu] * 1e37d0e 2022-12-19 | [voq][chassis]Add show fabric counters port/queue commands (sonic-net#2522) [jfeng-arista] * 17cdad3 2022-12-20 | [bufferorch] : Support for buffer profiles for VoQ on chassis (sonic-net#2465) [vmittal-msft] * 5345338 2023-01-04 | Disable `arp_evict_nocarrier` for vlan host intf (sonic-net#2590) [Longxiang Lyu] swss-common: * 9616287 2023-01-04 | Added customer monitoring tables in app db and state db (sonic-net#725) (HEAD -> 202205) [siqbal1986] * d03b95d 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#718) [Liu Shilong] * 8a276c6 2022-12-28 | Fix sonic-slave docker image environment issue. (sonic-net#728) (github/202205) [Liu Shilong] * 8fee1b4 2022-11-14 | Fix memory leak issue in ConfigDBConnector. (sonic-net#655) (sonic-net#706) [Hua Liu] sairedis: * 5387602 2022-11-30 | Use github code scanning instead of LGTM (#1160) (HEAD -> 202205) [Liu Shilong] platform-daemons: * b499412 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#316) (HEAD -> 202205, github/202205) [Liu Shilong] platform-common: * d11e983 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#328) (HEAD -> 202205) [Liu Shilong] py-swsssdk: * b654e91 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#131) (HEAD -> 202205) [Liu Shilong] Signed-off-by: Ying Xie <[email protected]>
…atform-common][py-swsssdk] advance submodule head (#13260) linkmgrd: * bf75a93 2022-11-30 | Use github code scanning instead of LGTM (#157) (HEAD -> 202205, github/202205) [Liu Shilong] utilities: * c1fa31d 2022-11-30 | Use github code scanning instead of LGTM (#2530) (HEAD -> 202205) [Liu Shilong] * 9990208 2022-05-19 | Add sonic-delayed.target to Application Extension .timer file generator (#2176) [noaOrMlnx] swss: * bbccc68 2023-01-04 | [vstest] Only collect stdout of orchagent_restart_check in vstest (#2597) (HEAD -> 202205, github/202205) [bingwang-ms] * f7a7c05 2023-01-04 | Avoid aborting orchagent when setting TUNNEL attributes (#2591) [Stephen Sun] * 84064fa 2022-12-20 | Fixed a bug causing error state of same configuration is applied twice. (#2580) [siqbal1986] * 4851bef 2022-12-20 | Only collect stdout of orchagent_restart_check in vstest (#2578) [bingwang-ms] * 2904d95 2022-12-05 | sonic-swss: Fix orchagent crash in generateQueueMapPerPort. (#2552) [Sambath Kumar Balasubramanian] * ac84e41 2022-11-30 | Use github code scanning instead of LGTM (#2546) [Liu Shilong] * 502bd69 2022-12-20 | Fix `test_vlan.py` (#2541) [Longxiang Lyu] * 1e37d0e 2022-12-19 | [voq][chassis]Add show fabric counters port/queue commands (#2522) [jfeng-arista] * 17cdad3 2022-12-20 | [bufferorch] : Support for buffer profiles for VoQ on chassis (#2465) [vmittal-msft] * 5345338 2023-01-04 | Disable `arp_evict_nocarrier` for vlan host intf (#2590) [Longxiang Lyu] swss-common: * 9616287 2023-01-04 | Added customer monitoring tables in app db and state db (#725) (HEAD -> 202205) [siqbal1986] * d03b95d 2022-11-30 | Use github code scanning instead of LGTM (#718) [Liu Shilong] * 8a276c6 2022-12-28 | Fix sonic-slave docker image environment issue. (#728) (github/202205) [Liu Shilong] * 8fee1b4 2022-11-14 | Fix memory leak issue in ConfigDBConnector. (#655) (#706) [Hua Liu] sairedis: * 5387602 2022-11-30 | Use github code scanning instead of LGTM (#1160) (HEAD -> 202205) [Liu Shilong] platform-daemons: * b499412 2022-11-30 | Use github code scanning instead of LGTM (#316) (HEAD -> 202205, github/202205) [Liu Shilong] platform-common: * d11e983 2022-11-30 | Use github code scanning instead of LGTM (#328) (HEAD -> 202205) [Liu Shilong] py-swsssdk: * b654e91 2022-11-30 | Use github code scanning instead of LGTM (#131) (HEAD -> 202205) [Liu Shilong] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>
…t#2552) * generateQueueMap uses m_portList[port].m_queue_ids.size to allocate m_queueStates in FlexCounterQueueStates. But m_portList[port].m_queue_ids.size is zero for system ports which results in isQueueCounterEnabled crash for system ports. Since we do not have support disable voq counters yet, do not check isQueueCounterEnabled for voqs.
- What I did
NOTE: A similar change will need to be applied to the master and 201811 branches.
- How to verify it
- A picture of a cute animal (not mandatory but encouraged)