Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule update for sonic-swss #2498

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Submodule update for sonic-swss #2498

merged 2 commits into from
Jan 30, 2019

Conversation

prsunny
Copy link
Contributor

@prsunny prsunny commented Jan 29, 2019

- What I did
Submodule update for sonic-swss for the following commits

commit dee34bc [wartermarkorch] Fix repeated m_pg_ids and m_unicast_queue_ids add up issue (#752)
commit 7375015 If available, read port settings from Config DB first (#723)
commit 230086b Revert "Fixed ACL IP type parser" (#762)
commit 5119b08 [VS] neighbor test post clean up to avoid messing up test environment (#760)
commit fd2eb4b Fixed ACL IP type parser. (#715)

- How I did it
NA

- How to verify it
NA

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Jan 29, 2019

to here. commit dee34bc [wartermarkorch] Fix repeated m_pg_ids and m_unicast_queue_ids add up issue (#752)

@prsunny prsunny merged commit 3f6ad44 into sonic-net:master Jan 30, 2019
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Nov 3, 2022
…n] update submodule head

linkmgrd:
* 8e9e49b 2022-11-02 | [active-standby][active-active] update link prober stats updating frequency to 30s (sonic-net#152) (HEAD -> 202205) [Jing Zhang]
* 1ad3f18 2022-11-01 | [Active-Active] periodically re-sync soc side admin forwarding state  (sonic-net#151) [Jing Zhang]
* cfcdb76 2022-11-01 | [202205] incrementing icmp buffer size (sonic-net#150) [Jing Zhang]

swss:
* ac7570a 2022-11-03 | [Dynamic buffer calculation][Mellanox] Enhance the logic to identify buffer pools and profiles (sonic-net#2498) (HEAD -> 202205) [Stephen Sun]

swss-common:
* 300fc8f 2022-10-31 | [sonic-db-cli] Fix sonic-db-cli crash when database config file not ready issue. (sonic-net#701) (HEAD -> 202205) [Hua Liu]

platform-daemon:
* cd1608a 2022-10-28 | [ycabled] add support for detach mode in 'active-active' topology (sonic-net#309) (HEAD -> 202205) [vdahiya12]
* 2a5f0f4 2022-10-27 | Added filtering logic to send filtered fields from DB event (sonic-net#307) [mihirpat1]

platform-common:
* b521882 2022-10-30 |  CmisApi::get_application_advertisement catch AttributeError as well (sonic-net#316) (HEAD -> 202205) [Stephen Sun]

Signed-off-by: Ying Xie <[email protected]>
yxieca added a commit that referenced this pull request Nov 3, 2022
…n] update submodule head (#12594)

linkmgrd:
* 8e9e49b 2022-11-02 | [active-standby][active-active] update link prober stats updating frequency to 30s (#152) (HEAD -> 202205) [Jing Zhang]
* 1ad3f18 2022-11-01 | [Active-Active] periodically re-sync soc side admin forwarding state  (#151) [Jing Zhang]
* cfcdb76 2022-11-01 | [202205] incrementing icmp buffer size (#150) [Jing Zhang]

swss:
* ac7570a 2022-11-03 | [Dynamic buffer calculation][Mellanox] Enhance the logic to identify buffer pools and profiles (#2498) (HEAD -> 202205) [Stephen Sun]

swss-common:
* 300fc8f 2022-10-31 | [sonic-db-cli] Fix sonic-db-cli crash when database config file not ready issue. (#701) (HEAD -> 202205) [Hua Liu]

platform-daemon:
* cd1608a 2022-10-28 | [ycabled] add support for detach mode in 'active-active' topology (#309) (HEAD -> 202205) [vdahiya12]
* 2a5f0f4 2022-10-27 | Added filtering logic to send filtered fields from DB event (#307) [mihirpat1]

platform-common:
* b521882 2022-10-30 |  CmisApi::get_application_advertisement catch AttributeError as well (#316) (HEAD -> 202205) [Stephen Sun]

Signed-off-by: Ying Xie <[email protected]>

Signed-off-by: Ying Xie <[email protected]>
prsunny pushed a commit that referenced this pull request Nov 11, 2022
swss update with following commits:
81f4ea9 orchagent/portsorch: Missing scheduler group after SWSS restart (#2174)
e557855 [SWSS] Innovium platform specific changes in PFC Detect lua script (#2493)
6e288dc New P4Orch development. (#2425)
ab0e474 swss: Fixing race condition for rif counters (#2488)
724f914 [tests] [asan] extend graceful stop flag to also stop syncd (#2491)
84642f3 [Dynamic buffer calculation][Mellanox] Enhance the logic to identify buffer pools and profiles (#2498)
e04bb43 Fix vs test issue: failed to remove vlan due to referenced by vlan interface (#2504)
52c561f Added LAG member check on addLagMember() (#2464)
tshalvi pushed a commit to tshalvi/sonic-buildimage that referenced this pull request Dec 20, 2022
…buffer pools and profiles (sonic-net#2498)

Signed-off-by: Stephen Sun <[email protected]>

What I did
Originally, it was assumed the names of all the buffer pools follow the community buffer pool name convention ({ingress|egress}_{lossless|lossy}_pool). The heuristic algorithm to identify buffer pools and profiles was designed based on the assumption.
However, some users can define the buffer pool names in other ways, which breaks the logic in the Lua plugin and introduces degradation,

the pool sizes of those pools can not be generated
the additional reserved memory for lossy PG can not be calculated
In this PR, the logic is improved to tolerate the case.
Signed-off-by: Stephen Sun [email protected]

How I verified it
Manually and regression test.
It has been covered by regression test and vs test. No new test case is required.

Details if related
Separate the buffer pools into two tables according to the direction.
Iterate all the profiles, generating and recording the type (lossless/lossy) for each ingress profile which is identified by checking the pool it references
Identify buffer profiles for lossy PG by checking the type (lossless/lossy) generated in 2 instead of the hardcoded name ingress_lossy_profile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants