-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YANG] SRv6 yang model followup fix #21466
Conversation
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -92,20 +92,20 @@ | |||
"sonic-srv6:SRV6_MY_SIDS": { | |||
"SRV6_MY_SIDS_LIST": [ | |||
{ | |||
"ip_address": "FCBB:BBBB:20::", | |||
"ip_prefix": "FCBB:BBBB:20::/48", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
locator is "MAIN" not "None"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these configurations are set to be erotic to test whether the YANG model can correctly identify the errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
@@ -170,39 +170,12 @@ | |||
"sonic-srv6:SRV6_MY_SIDS": { | |||
"SRV6_MY_SIDS_LIST": [ | |||
{ | |||
"ip_address": "FCBB:BBBB:20::", | |||
"ip_prefix": "FCBB:BBBB:20::/48", | |||
"locator": "MAIN", | |||
"action": "uA" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
action is "uN"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
@@ -118,20 +118,20 @@ | |||
"sonic-srv6:SRV6_MY_SIDS": { | |||
"SRV6_MY_SIDS_LIST": [ | |||
{ | |||
"ip_address": "FCBB:BBBB:200001::", | |||
"ip_prefix": "FCBB:BBBB:21::", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the prefix len "/48"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
Change the YANG schema of the SRv6 module to use an ipv6-prefix type for the key of the SRV6_MY_SIDS table.
Conflict resolved after #21175 is merged. Local cherry-pick works. |
Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#543 |
Why I did it
Change the YANG schema of the SRv6 module to use an ipv6-prefix type for the key of the SRV6_MY_SIDS table.
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)