-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling ports by adding parameter ‘-P 0’ #21296
Merged
StormLiangMS
merged 1 commit into
sonic-net:master
from
yyynini:yawenni/port_disable_202411
Dec 30, 2024
Merged
Disabling ports by adding parameter ‘-P 0’ #21296
StormLiangMS
merged 1 commit into
sonic-net:master
from
yyynini:yawenni/port_disable_202411
Dec 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
StormLiangMS
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
Why I did it There are several TCP ports bound to localhost that need to be disabled to enhance system security. Work item tracking Microsoft ADO (number only): How I did it By adding -P 0 in supervisord.conf.j2 to disable the ports. How to verify it Check the file for -P 0 changes, and confirm port behaviour using netstat.
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
Why I did it There are several TCP ports bound to localhost that need to be disabled to enhance system security. Work item tracking Microsoft ADO (number only): How I did it By adding -P 0 in supervisord.conf.j2 to disable the ports. How to verify it Check the file for -P 0 changes, and confirm port behaviour using netstat.
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
Why I did it There are several TCP ports bound to localhost that need to be disabled to enhance system security. Work item tracking Microsoft ADO (number only): How I did it By adding -P 0 in supervisord.conf.j2 to disable the ports. How to verify it Check the file for -P 0 changes, and confirm port behaviour using netstat.
8 tasks
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
Why I did it There are several TCP ports bound to localhost that need to be disabled to enhance system security. Work item tracking Microsoft ADO (number only): How I did it By adding -P 0 in supervisord.conf.j2 to disable the ports. How to verify it Check the file for -P 0 changes, and confirm port behaviour using netstat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
There are several TCP ports bound to localhost that need to be disabled to enhance system security.
Work item tracking
How I did it
By adding -P 0 in supervisord.conf.j2 to disable the ports.
How to verify it
Check the file for -P 0 changes, and confirm port behaviour using netstat.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)