-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Banner: Remove dependency on sshd service #21264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case Signed-off-by: Yevhen Fastiuk <[email protected]>
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Dec 24, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 24, 2024
- Why I did it Fixes sonic-net#19661 - How I did it Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case - How to verify it Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds. Signed-off-by: Yevhen Fastiuk <[email protected]>
Cherry-pick PR to 202405: #21273 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 25, 2024
- Why I did it Fixes #19661 - How I did it Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case - How to verify it Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds. Signed-off-by: Yevhen Fastiuk <[email protected]>
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
- Why I did it Fixes sonic-net#19661 - How I did it Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case - How to verify it Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds. Signed-off-by: Yevhen Fastiuk <[email protected]>
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
- Why I did it Fixes sonic-net#19661 - How I did it Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case - How to verify it Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds. Signed-off-by: Yevhen Fastiuk <[email protected]>
github-actions bot
pushed a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jan 2, 2025
- Why I did it Fixes sonic-net#19661 - How I did it Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case - How to verify it Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds. Signed-off-by: Yevhen Fastiuk <[email protected]>
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
- Why I did it Fixes sonic-net#19661 - How I did it Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case - How to verify it Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds. Signed-off-by: Yevhen Fastiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19661
Why I did it
Work item tracking
How I did it
Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case
How to verify it
Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (it is my cat Finn)