Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner: Remove dependency on sshd service #21264

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

fastiuk
Copy link
Contributor

@fastiuk fastiuk commented Dec 23, 2024

fixes #19661

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case

How to verify it

Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (it is my cat Finn)

PXL_20230413_140941610 PORTRAIT

* Banner service will save the config data into the
file after setting the config, so it will be
available after the boot in any case

Signed-off-by: Yevhen Fastiuk <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik merged commit 186c9b7 into sonic-net:master Dec 24, 2024
22 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 24, 2024
- Why I did it
Fixes sonic-net#19661

- How I did it
Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case

- How to verify it
Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds.

Signed-off-by: Yevhen Fastiuk <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #21273

mssonicbld pushed a commit that referenced this pull request Dec 25, 2024
- Why I did it
Fixes #19661

- How I did it
Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case

- How to verify it
Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds.

Signed-off-by: Yevhen Fastiuk <[email protected]>
github-actions bot pushed a commit to bradh352/sonic-buildimage that referenced this pull request Jan 2, 2025
- Why I did it
Fixes sonic-net#19661

- How I did it
Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case

- How to verify it
Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds.

Signed-off-by: Yevhen Fastiuk <[email protected]>
github-actions bot pushed a commit to bradh352/sonic-buildimage that referenced this pull request Jan 2, 2025
- Why I did it
Fixes sonic-net#19661

- How I did it
Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case

- How to verify it
Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds.

Signed-off-by: Yevhen Fastiuk <[email protected]>
github-actions bot pushed a commit to bradh352/sonic-buildimage that referenced this pull request Jan 2, 2025
- Why I did it
Fixes sonic-net#19661

- How I did it
Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case

- How to verify it
Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds.

Signed-off-by: Yevhen Fastiuk <[email protected]>
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
- Why I did it
Fixes sonic-net#19661

- How I did it
Removed the dependency on sshd service. Banner service will save the config data into the file after setting the config, so it will be available after the boot in any case

- How to verify it
Reboot the switch and wait for the serial prompt. SSH should become available after a couple of seconds.

Signed-off-by: Yevhen Fastiuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[202405] delayed ssh service start due to dependency caused by banner-config service
5 participants