Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced minigraph parser for packet-chasiss production graph #21255

Merged
merged 11 commits into from
Jan 2, 2025

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Dec 21, 2024

What I did:
Fixed 2 issue while parsing production minigraph:

  1. bfd flag not being set for STATIC_ROUTE table
  2. Different mac-address not getting generated for each ASIC

How I fixed:
In production switch_type is derived using ForwardingMethod attribute. Modified code to use chassis_type which is derived using ForwardingMethod

How I verify:
Added UT
Manual Verification.

MSFT ADO: 30791293

via NETLINK RTA_PRIORITY field which can be used as attribute/metadata
in fpmsyncd for different use-cases.

Signed-off-by: Abhishek Dosi <[email protected]>
…K RTA_PRIORITY field which can be used as attribute/metadata in fpmsyncd for different use-cases.

Signed-off-by: Abhishek Dosi <[email protected]>
…a NETLINK RTA_PRIORITY field which can be used as attribute/metadata in fpmsyncd for different use-cases."

This reverts commit 2776138.
@abdosi abdosi changed the title Frr patch Enhanced minigraph parser for packet-chasiss production graph Dec 21, 2024
@abdosi abdosi requested a review from arlakshm December 21, 2024 07:08
@abdosi
Copy link
Contributor Author

abdosi commented Dec 21, 2024

@rlhui @yejianquan for viz.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit b78ad9b.
Signed-off-by: Abhishek Dosi <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor Author

abdosi commented Dec 24, 2024

@rlhui for viz. @qiluo-msft this is bug fix so we should be able to get exception on this.

@qiluo-msft qiluo-msft requested a review from wen587 January 2, 2025 18:38
@abdosi
Copy link
Contributor Author

abdosi commented Jan 2, 2025

@rlhui : can you help with merge of this

@rlhui rlhui merged commit 0ed3434 into sonic-net:master Jan 2, 2025
21 of 22 checks passed
@abdosi abdosi deleted the frr-patch branch January 8, 2025 00:24
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202405: Azure/sonic-buildimage-msft#501

VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
…net#21255)

Fixed 2 issue while parsing production minigraph:

bfd flag not being set for STATIC_ROUTE table
Different mac-address not getting generated for each ASIC

How I fixed:
In production switch_type is derived using ForwardingMethod attribute. Modified code to use chassis_type which is derived using ForwardingMethod

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants