Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] get_error_descripton should return Not supported for modules that does not support this API #21196

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

Junchao-Mellanox
Copy link
Collaborator

Why I did it

Not all xcvr API support get_error_description, for example sff8636. For those API types, get_error_description should return "Not supported".

Work item tracking
  • Microsoft ADO (number only):

How I did it

get_error_description should return "Not supported".

How to verify it

Manual test
unit test

Which release branch to backport (provide reason below if selected)

  • 202411

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox
Copy link
Collaborator Author

/azpw ms_conflict

@Junchao-Mellanox
Copy link
Collaborator Author

Hi @StormLiangMS , could you please help check the ms conflict?

@liat-grozovik
Copy link
Collaborator

/azpw ms_conflict

@liat-grozovik
Copy link
Collaborator

Hi @StormLiangMS , could you please help check the ms conflict?

@StormLiangMS kindly reminder as we are blocked for this PR

@liat-grozovik
Copy link
Collaborator

@Junchao-Mellanox is it needed only for master/202411? why not 202405?

@Junchao-Mellanox
Copy link
Collaborator Author

Also needs for 202405 since the previous PR was in 202405.

dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request Jan 15, 2025
@liat-grozovik
Copy link
Collaborator

/azpw run ms_conflict

@kperumalbfn
Copy link
Contributor

@liushilongbuaa could you pls check the ms_conflict failure?

ayurkiv-nvda pushed a commit to ayurkiv-nvda/sonic-buildimage that referenced this pull request Jan 22, 2025
@liushilongbuaa
Copy link
Contributor

/azpw ms_conflict

@liat-grozovik liat-grozovik merged commit 9b9da85 into sonic-net:master Jan 23, 2025
12 checks passed
tshalvi pushed a commit to tshalvi/sonic-buildimage that referenced this pull request Jan 23, 2025
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Jan 27, 2025
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #21537

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #21541

@bingwang-ms
Copy link
Contributor

@Junchao-Mellanox
Copy link
Collaborator Author

@Junchao-Mellanox There should be another PR to update the expectation in sonic-mgmt test. https://github.com/sonic-net/sonic-mgmt/blob/db2df148ed793d5292acc60588120d13d3b6fade/tests/platform_tests/sfp/test_sfputil.py#L365

Yes, someone from Nvidia will handle it.

@Junchao-Mellanox Junchao-Mellanox deleted the master-error-desc branch January 28, 2025 04:44
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request Jan 29, 2025
dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request Jan 29, 2025
@nhe-NV
Copy link

nhe-NV commented Feb 5, 2025

@Junchao-Mellanox There should be another PR to update the expectation in sonic-mgmt test. https://github.com/sonic-net/sonic-mgmt/blob/db2df148ed793d5292acc60588120d13d3b6fade/tests/platform_tests/sfp/test_sfputil.py#L365

Yes, someone from Nvidia will handle it.

It is handled in the PR: sonic-net/sonic-mgmt#16573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants