-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] get_error_descripton should return Not supported for modules that does not support this API #21196
[Mellanox] get_error_descripton should return Not supported for modules that does not support this API #21196
Conversation
…les that does not support this API
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw ms_conflict |
Hi @StormLiangMS , could you please help check the ms conflict? |
/azpw ms_conflict |
@StormLiangMS kindly reminder as we are blocked for this PR |
@Junchao-Mellanox is it needed only for master/202411? why not 202405? |
Also needs for 202405 since the previous PR was in 202405. |
…pported for modules that does not support this API (sonic-net#21196)
/azpw run ms_conflict |
@liushilongbuaa could you pls check the ms_conflict failure? |
…pported for modules that does not support this API (sonic-net#21196)
/azpw ms_conflict |
…pported for modules that does not support this API (sonic-net#21196)
…d for modules that does not support this API sonic-net#21196
Cherry-pick PR to 202411: #21537 |
Cherry-pick PR to 202405: #21541 |
@Junchao-Mellanox There should be another PR to update the expectation in sonic-mgmt test. https://github.com/sonic-net/sonic-mgmt/blob/db2df148ed793d5292acc60588120d13d3b6fade/tests/platform_tests/sfp/test_sfputil.py#L365 |
Yes, someone from Nvidia will handle it. |
…pported for modules that does not support this API (sonic-net#21196)
…pported for modules that does not support this API (sonic-net#21196)
It is handled in the PR: sonic-net/sonic-mgmt#16573 |
Why I did it
Not all xcvr API support get_error_description, for example sff8636. For those API types, get_error_description should return "Not supported".
Work item tracking
How I did it
get_error_description should return "Not supported".
How to verify it
Manual test
unit test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)