Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libasan to version 8 in docker-syncd-mlnx to align with bookworm libasan #21134

Merged

Conversation

ayurkiv-nvda
Copy link
Contributor

@ayurkiv-nvda ayurkiv-nvda commented Dec 11, 2024

Why I did it

syncd is linking to libasan v8 during build after the bookwork upgrade #18651 but libasan v6 is installed in the syncd container for the mellanox platform which is causing runtime errors.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Install libasan8 on docker-syncd-mlnx

How to verify it

Build sonic with ENABLE_ASAN=y and verify syncd starts successfully.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202405

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@saiarcot895 saiarcot895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to comment suggesting removing the explicit libasan8 installation, but I see the library dependencies for syncd are listed in Recommends, so there's no strict guarantee for them to get installed.

@lguohan lguohan merged commit 5eb2556 into sonic-net:master Dec 16, 2024
12 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 18, 2024
…n with bookworm libasan (sonic-net#21134)

syncd is linking to libasan v8 during build after the bookwork upgrade sonic-net#18651 but libasan v6 is installed in the syncd container for the mellanox platform which is causing runtime errors.

Signed-off-by: Andriy Yurkiv <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #21213

bingwang-ms pushed a commit that referenced this pull request Dec 27, 2024
…n with bookworm libasan (#21134) (#21213)

syncd is linking to libasan v8 during build after the bookwork upgrade #18651 but libasan v6 is installed in the syncd container for the mellanox platform which is causing runtime errors.

Signed-off-by: Andriy Yurkiv <[email protected]>
Co-authored-by: Andriy Yurkiv <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #21404

dgsudharsan pushed a commit to dgsudharsan/sonic-buildimage that referenced this pull request Jan 15, 2025
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
…n with bookworm libasan (sonic-net#21134)

syncd is linking to libasan v8 during build after the bookwork upgrade sonic-net#18651 but libasan v6 is installed in the syncd container for the mellanox platform which is causing runtime errors.

Signed-off-by: Andriy Yurkiv <[email protected]>
ayurkiv-nvda pushed a commit to ayurkiv-nvda/sonic-buildimage that referenced this pull request Jan 22, 2025
tshalvi pushed a commit to tshalvi/sonic-buildimage that referenced this pull request Jan 23, 2025
@ayurkiv-nvda ayurkiv-nvda deleted the libasan8_upgrade_master_upstream branch February 5, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants