[Bookworm] Fix timezone propagation to containers #21079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
approved these changes
Dec 6, 2024
|
/azpw run ms_conflict |
|
/AzurePipelines run ms_conflict |
|
No pipelines are associated with this pull request. |
|
@nmoray FYI |
|
thanks @vivekrnv for the fix. |
|
/azpw ms_conflict |
|
@saiarcot895 would you like to review or suggest someone else? if not, i would take Sud approval as good enough and merge |
saiarcot895
approved these changes
Dec 11, 2024
liat-grozovik
approved these changes
Dec 11, 2024
11 tasks
11 tasks
|
Cherry-pick PR to 202411: #21406 |
dgsudharsan
pushed a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Jan 15, 2025
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
- Why I did it Fix sonic-net#20925 Not cherry-pickable to 202405, will raise a separate PR - How I did it Mount /etc/localtime on containers and remove /etc/timezone dependency - How to verify it root@sonic:/home/admin# zdump /etc/localtime /etc/localtime Fri Dec 6 23:24:03 2024 IST root@sonic:/home/admin# docker exec swss zdump /etc/localtime /etc/localtime Fri Dec 6 23:24:12 2024 IST Verify swss.rec/sairedis.rec and syslog are following same time Signed-off-by: Vivek <[email protected]>
ayurkiv-nvda
pushed a commit
to ayurkiv-nvda/sonic-buildimage
that referenced
this pull request
Jan 22, 2025
tshalvi
pushed a commit
to tshalvi/sonic-buildimage
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix #20925
Not cherry-pickable to 202405, will raise a separate PR
How I did it
Mount /etc/localtime on containers and remove /etc/timezone dependency
How to verify it
Verify swss.rec/sairedis.rec and syslog are following same time
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)