[yang] LOGGER missing require_manual_refresh #20969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of sonic-net#19611 and sonic-net/sonic-utilities#3428 a new database field of `require_manual_refresh` was added. This leads to YANG failures in the factory-default configuration for the `xcvrd` log entry which by default is written as true. Signed-off-by: Brad House (@bradh352)
|
@Junchao-Mellanox please review since your PRs caused the YANG breakage. Also @xincunli-sonic, @prgeor, @keboliu who approved the PR. |
Junchao-Mellanox
approved these changes
Dec 2, 2024
xincunli-sonic
approved these changes
Dec 2, 2024
ganglyu
approved these changes
Dec 4, 2024
|
@qiluo-msft would you please merge this PR? |
dgsudharsan
approved these changes
Dec 6, 2024
|
Hi @qiluo-msft please help merge it. |
|
lgtm |
|
@bradh352 , As this PR need to be taken onto 202411 as well, and there are conflicts, can you please provide PR Vs. 202411 ? |
|
@dprital actually the PR got merged before branching, so its already in 202411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
YANG failures during
config replacewith default configuration.As of #19611 and sonic-net/sonic-utilities#3428 a new database field of
require_manual_refreshwas added.This leads to YANG failures in the factory-default configuration for the
xcvrdlog entry which by default is written as true.Work item tracking
How I did it
Updated YANG file for new field.
How to verify it
Verify
config replaceworks with factory default configuration.Which release branch to backport (provide reason below if selected)
None, this only exists in master.
Tested branch (Please provide the tested image version)
master as of 20241129
Description for the changelog
[yang] LOGGER missing require_manual_refresh
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Brad House (@bradh352)