Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[syncd] warn shutdown syncd process when warm boot is enabled #2078

Merged
merged 3 commits into from
Oct 2, 2018

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Sep 25, 2018

Signed-off-by: Ying Xie [email protected]

- What I did
When syncd service is stopping during warm reboot. Give syncd enough time to gracefully shutdown and save states.

- How to verify it
Set global warm shutdown flag, shutdown syncd service, make sure that the SAI state has been saved to specified file.

(However, full verification will have to wait until warm recover is in place).

Also what missing from this PR is definition of follow sample entries in sai.profile:
SAI_WARM_BOOT_READ_FILE=/var/warmboot/sai-warmboot.bin
SAI_WARM_BOOT_WRITE_FILE=/var/warmboot/sai-warmboot.bin

@yxieca yxieca requested review from lguohan and kcudnik September 25, 2018 00:15
files/scripts/syncd.sh Outdated Show resolved Hide resolved
@yxieca yxieca merged commit c8e6b15 into sonic-net:master Oct 2, 2018
@yxieca yxieca deleted the warmshut branch October 2, 2018 02:01
judyjoseph added a commit that referenced this pull request Mar 20, 2022
9968d60 (HEAD -> 202111, origin/202111) [sonic-package-manager] do not mod_config for whole config db when setting init_cfg (#2055)
4b3d53f [generate_dump] exclude mft and mlx folders from /etc (#2072)
51d92ae Validation check correction while adding a member to PortChannel (#2078)
6a43306 [techsupport] Added a lock to avoid running techsupport in parallel (#2065)
44cfdd9 Try get port operational speed from STATE DB (#2030)
45ea623 Fix sonic-installer failure due to missing import
taras-keryk pushed a commit to taras-keryk/sonic-buildimage that referenced this pull request Apr 28, 2022
…ic-net#2078)

Corrected the validation check while adding a member to a PortChannel

This PR will fix the issue - sonic-net#9908

The CLI command should reject when trying to add member to a Portchannel when link-local is enabled in it.
``
root@sonic:/home/admin# config ipv6 enable link-local
root@sonic:/home/admin#
root@sonic:/home/admin# config portchannel add PortChannel0001
root@sonic:/home/admin#
root@sonic:/home/admin# config portchannel member add PortChannel0001 Ethernet64
Usage: config portchannel member add [OPTIONS] <portchannel_name> <port_name>
Try "config portchannel member add -h" for help.

Error:  Ethernet64 has ip address configured
root@sonic:/home/admin#
``
Signed-off-by: Akhilesh Samineni [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants