Build and include tacacs+ for PTF Py3 only image #20701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwjiang-ms
approved these changes
Dec 2, 2024
wangxin
reviewed
Dec 3, 2024
| && make install \ | ||
| && ln -s /usr/local/sbin/tac_plus /usr/sbin/tac_plus \ | ||
| && ln -s /usr/local/bin/tac_pwd /usr/sbin/tac_pwd | ||
| {% endif %} |
There was a problem hiding this comment.
Why not use the source code from an organization like https://github.com/facebook/tac_plus
I assume it would be better than the fork of a personal account?
There was a problem hiding this comment.
@wangxin thanks. I have updated the repo.
wangxin
approved these changes
Dec 6, 2024
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
Why I did it The "tacacs+" package is not available in the apt repository for Debian Bullseye and beyond. The sonic-mgmt tests require tacacs+ and this PR builds it from source and adds it to the PY3 only image. Work item tracking Microsoft ADO (number only): 29946202 How I did it Clone tacacs+ from https://github.com/robot527/tac_plus build and install it. How to verify it By running sonic-mgmt restart-ptf step with newly built image. Tested branch (Please provide the tested image version) Not applicable. Description for the changelog [docker-ptf]: Build and include tacacs+ for py3only image The "tacacs+" package is not available in the apt repository for Debian Bullseye and beyond. The sonic-mgmt tests require tacacs+ and this commit builds it from source and adds it to the PY3 only image. Link to config_db schema for YANG module changes Not applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The "tacacs+" package is not available in the apt repository for Debian Bullseye and beyond. The sonic-mgmt tests require tacacs+ and this PR builds it from source and adds it to the PY3 only image.
Work item tracking
How I did it
Clone tacacs+ from https://github.com/robot527/tac_plus build and install it.
How to verify it
By running sonic-mgmt restart-ptf step with newly built image.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Not applicable.
Description for the changelog
[docker-ptf]: Build and include tacacs+ for py3only image
Link to config_db schema for YANG module changes
Not applicable.
A picture of a cute animal (not mandatory but encouraged)