[FRR Patch] Added patch in FRR to send tag value associated with route via Netlink to fpmsyncd #20692
Conversation
via NETLINK RTA_PRIORITY field which can be used as attribute/metadata in fpmsyncd for different use-cases. Signed-off-by: Abhishek Dosi <[email protected]>
|
@StormLiangMS for viz |
| ri->rtm_type = RTN_UNICAST; | ||
| - ri->metric = &re->metric; | ||
| + // Patch to send tag value via NETLINK Priority field (RTA_PRIORITY). The Tag vale can be used as metadata/attribute in fpmsyncd for further processing | ||
| + ri->metric = &re->tag; |
There was a problem hiding this comment.
Given now we migrated to dplane_fpm_sonic, does it require any changes over there?
There was a problem hiding this comment.
@dgsudharsan thanks. i have revised the patch. Change is now inside API netlink_route_multipath_msg_encode which is called by both dplane_fpm_sonic.c and dplane_fpm_nl.c
|
|
||
| ri->rtm_protocol = netlink_proto_from_route_type(re->type); | ||
| ri->rtm_type = RTN_UNICAST; | ||
| - ri->metric = &re->metric; |
There was a problem hiding this comment.
We are overriding the current meaning of metric by default. Would it impact any existing usecases/ scenarios?
There was a problem hiding this comment.
@dgsudharsan not applicable as change has been revised. please review again.
This reverts commit a279d8e.
…K RTA_PRIORITY field which can be used as attribute/metadata in fpmsyncd for different use-cases. Signed-off-by: Abhishek Dosi <[email protected]>
|
@dgsudharsan : can you review again |
There was a problem hiding this comment.
@abdosi I request you to wait for FRR 10.0.1 merge and rebase this PR based on it. @hasan-brcm FYI
…a NETLINK RTA_PRIORITY field which can be used as attribute/metadata in fpmsyncd for different use-cases." This reverts commit 2776138.
Signed-off-by: Abhishek Dosi <[email protected]>
@dgsudharsan : Please approve again. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#496 |
…e via Netlink to fpmsyncd (sonic-net#20692) * Added patch in FRR to send tag value associated with route via NETLINK RTA_PRIORITY field which can be used as attribute/metadata in fpmsyncd for different use-cases. --------- Signed-off-by: Abhishek Dosi <[email protected]>
What I did:
Added patch in FRR to send tag value associated with route via NETLINK RTA_PRIORITY field which can be used as attribute/metadata in fpmsyncd for different use-cases.
Why I did:
Some of use cases:
How I verify:
Manual Verification.