Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arista] Update platform library submodules #20603

Closed
wants to merge 1 commit into from

Conversation

Staphylo
Copy link
Collaborator

Why I did it

  • Add support for new psus
  • Add support for new fan modules
  • Report fan information from all fabric cards
  • Fix psud warning due to invalid pmbus threshold reported
  • Disable lpmode for chassis
Work item tracking
  • Microsoft ADO (number only):

How I did it

Updated our platform driver submodules

How to verify it

Changes validated against sonic-mgmt 202405 and master

Description for the changelog

Update Arista platform library submodules

@Staphylo Staphylo requested a review from lguohan as a code owner October 24, 2024 11:57
@kenneth-arista
Copy link
Contributor

@arlakshm @wenyiz2021 for viz

@arlakshm
Copy link
Contributor

Hi @Staphylo, @kenneth-arista,
do we need the change to disable lpmode for chassis in the platform driver? I thought the change is done in xcvr to fix the lpmode issue on the chassis?

@kenneth-arista
Copy link
Contributor

Hi @Staphylo, @kenneth-arista, do we need the change to disable lpmode for chassis in the platform driver? I thought the change is done in xcvr to fix the lpmode issue on the chassis?

The change to disable lpmode for chassis in the platform library is a temporary work around while the fix to xcvrd is being worked on.

@prgeor
Copy link
Contributor

prgeor commented Nov 5, 2024

Hi @Staphylo, @kenneth-arista, do we need the change to disable lpmode for chassis in the platform driver? I thought the change is done in xcvr to fix the lpmode issue on the chassis?

The change to disable lpmode for chassis in the platform library is a temporary work around while the fix to xcvrd is being worked on.

@Staphylo @kenneth-arista can we avoid hacking here? Looks like you don't want to own the change on Xcvrd code

@patrickmacarthur
Copy link
Contributor

I have opened PR #20929 to supersede this PR; it includes a revert for the "Disable lpmode on chassis" commit that was included in this PR

@rlhui
Copy link
Contributor

rlhui commented Nov 27, 2024

I have opened PR #20929 to supersede this PR; it includes a revert for the "Disable lpmode on chassis" commit that was included in this PR

please close this one then, thanks.

@patrickmacarthur
Copy link
Contributor

patrickmacarthur commented Nov 27, 2024

I have opened PR #20929 to supersede this PR; it includes a revert for the "Disable lpmode on chassis" commit that was included in this PR

please close this one then, thanks.

This is Samuel's PR so I don't have permissions to close it.

@rlhui
Copy link
Contributor

rlhui commented Nov 27, 2024

I have opened PR #20929 to supersede this PR; it includes a revert for the "Disable lpmode on chassis" commit that was included in this PR

please close this one then, thanks.

This is Samuel's PR so I don't have permissions to close it.

@Staphylo would you be closing this PR? thanks.

@Staphylo
Copy link
Collaborator Author

Staphylo commented Dec 2, 2024

Closing as discussed

@Staphylo Staphylo closed this Dec 2, 2024
lguohan pushed a commit that referenced this pull request Dec 11, 2024
(this is a replacement for PR #20603; this PR includes a revert for the "Disable lpmode for chassis" change)

Add support for new psus
Add support for new fan modules
Report fan information from all fabric cards
Fix psud warning due to invalid pmbus threshold reported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants