Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256 #20548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenxs
changed the title
|
@r12f Can you help review this PR? |
keboliu
approved these changes
Oct 29, 2024
r12f
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
looks straight-forward good to me. Since it changes config and YANG model, I am going to request @qiluo-msft to look at it as well.
qiluo-msft
reviewed
Nov 11, 2024
ganglyu
reviewed
Nov 12, 2024
ganglyu
reviewed
Nov 12, 2024
ganglyu
approved these changes
Nov 12, 2024
qiluo-msft
previously approved these changes
Nov 13, 2024
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DavidZagury
reviewed
Nov 15, 2024
device/mellanox/x86_64-nvidia_sn5600-r0/Mellanox-SN5600-C256X1/supporting_bulk_counter_groups
Outdated
Show resolved
Hide resolved
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
Signed-off-by: Stephen Sun <[email protected]>
stephenxs
force-pushed
the
supporting_bulk_counter_groups
branch
from
c962c80 to
c5315a5
Compare
stephenxs
changed the title
|
Rebase to resolve the conflict and remove a no-longer used SKU. |
DavidZagury
approved these changes
Nov 15, 2024
|
/ms_conflict |
3 similar comments
|
/ms_conflict |
|
/ms_conflict |
|
/ms_conflict |
qiluo-msft
reviewed
Nov 19, 2024
|
@bingwang-ms who can assist with ms_conflict and merge this one? |
|
/azpw ms_conflict |
|
@qiluo-msft would you please help to review and merge it? thanks |
qiluo-msft
approved these changes
Nov 28, 2024
stephenxs
added a commit
to stephenxs/sonic-buildimage
that referenced
this pull request
Nov 29, 2024
…|localhost for Mellanox-SN5600-V256 (sonic-net#20548) Why I did it Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 2, 2024
…|localhost for Mellanox-SN5600-V256 (sonic-net#20548) Why I did it Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256
|
Cherry-pick PR to 202405: #20993 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 4, 2024
…|localhost for Mellanox-SN5600-V256 (#20548) Why I did it Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
11 tasks
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
…|localhost for Mellanox-SN5600-V256 (sonic-net#20548) Why I did it Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256
liat-grozovik
pushed a commit
that referenced
this pull request
Feb 5, 2025
…alization for SN5640 (port #20548 to ACS-SN5640) (#21474) This is to port #20548 to ACS-SN5640 Signed-off-by: Stephen Sun <[email protected]>
yuazhe
pushed a commit
to yuazhe/sonic-buildimage
that referenced
this pull request
Feb 12, 2025
…during initialization for SN5640 (port sonic-net#20548 to ACS-SN5640)
saiarcot895
pushed a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
Feb 13, 2025
…alization for SN5640 (port sonic-net#20548 to ACS-SN5640) (sonic-net#592) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it This is to port sonic-net#20548 to ACS-SN5640 ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it #### How to verify it <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
yuazhe
pushed a commit
to yuazhe/sonic-buildimage
that referenced
this pull request
Feb 18, 2025
…during initialization for SN5640 (port sonic-net#20548 to ACS-SN5640) (%21474)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Support new field "supporting_bulk_counter_groups" in DEVICE_METADATA|localhost for Mellanox-SN5600-V256
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)