[yang] add Yang model for XCVRD_LOG|Y_CABLE #20496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaibhav Dahiya <[email protected]>
Signed-off-by: Vaibhav Dahiya <[email protected]>
prgeor
previously approved these changes
Oct 14, 2024
|
sonic-yang-mgmt unit test is broken |
ganglyu
reviewed
Oct 14, 2024
| "Y_CABLE": { | ||
| "log_verbosity": "notice" | ||
| } | ||
| }, |
There was a problem hiding this comment.
This table should be at the same level as BANNER_MESSAGE.
Signed-off-by: Vaibhav Dahiya <[email protected]>
wen587
reviewed
Oct 15, 2024
| @@ -2723,6 +2728,7 @@ | |||
| } | |||
| } | |||
| }, | |||
|
|
|||
Signed-off-by: Vaibhav Dahiya <[email protected]>
ganglyu
approved these changes
Oct 15, 2024
wen587
approved these changes
Oct 16, 2024
Signed-off-by: Vaibhav Dahiya <[email protected]>
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Commenter does not have sufficient privileges for PR 20496 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qiluo-msft , please help merge |
qiluo-msft
approved these changes
Oct 29, 2024
|
Hi @vdahiya12 , please help contact branch owner and backport to previous branch |
rkavitha-hcl
pushed a commit
to rkavitha-hcl/sonic-buildimage
that referenced
this pull request
Nov 15, 2024
#### Why I did it Adding yang model for CONFIG_DB table XCVRD_LOG|Y_CABLE. Introduced by https://github.com/sonic-net/sonic-utilities/blob/master/config/muxcable.py#L1230-L1235 #### How I did it Added the changes in sonic-yang-models #### How to verify it UT test ``` ==================================================================================== test session starts ==================================================================================== platform linux -- Python 3.9.2, pytest-6.0.2, py-1.10.0, pluggy-0.13.0 rootdir: /sonic/src/sonic-yang-models plugins: pyfakefs-5.2.3, cov-2.10.1 collected 3 items tests/test_sonic_yang_models.py .. [ 66%] tests/yang_model_tests/test_yang_model.py . [100%] ===================================================================================== 3 passed in 2.06s ===================================================================================== ```
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
#### Why I did it Adding yang model for CONFIG_DB table XCVRD_LOG|Y_CABLE. Introduced by https://github.com/sonic-net/sonic-utilities/blob/master/config/muxcable.py#L1230-L1235 #### How I did it Added the changes in sonic-yang-models #### How to verify it UT test ``` ==================================================================================== test session starts ==================================================================================== platform linux -- Python 3.9.2, pytest-6.0.2, py-1.10.0, pluggy-0.13.0 rootdir: /sonic/src/sonic-yang-models plugins: pyfakefs-5.2.3, cov-2.10.1 collected 3 items tests/test_sonic_yang_models.py .. [ 66%] tests/yang_model_tests/test_yang_model.py . [100%] ===================================================================================== 3 passed in 2.06s ===================================================================================== ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Adding yang model for CONFIG_DB table XCVRD_LOG|Y_CABLE.
Introduced by
https://github.com/sonic-net/sonic-utilities/blob/master/config/muxcable.py#L1230-L1235
sign-off: Vaibhav Dahiya [[email protected]]
Work item tracking
How I did it
Added the changes in sonic-yang-models
How to verify it
UT test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)