Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Fix component versions caching bug #19982

Merged

Conversation

skr31
Copy link
Contributor

@skr31 skr31 commented Aug 22, 2024

Why I did it

The component versions file that is created during compilation was not being updated because it was being cached, even when some of the versions on it should have been updated.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Removed component-versions.dep

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@skr31 skr31 requested a review from lguohan as a code owner August 22, 2024 07:40
@skr31 skr31 force-pushed the fix_version_component_caching branch from a57b184 to 21360b4 Compare August 22, 2024 08:06
@liushilongbuaa
Copy link
Contributor

/azpw ms_conflict -f

@skr31
Copy link
Contributor Author

skr31 commented Aug 25, 2024

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@skr31
Copy link
Contributor Author

skr31 commented Sep 2, 2024

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@skr31
Copy link
Contributor Author

skr31 commented Sep 9, 2024

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@skr31
Copy link
Contributor Author

skr31 commented Sep 10, 2024

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin
Copy link
Contributor

wangxin commented Oct 8, 2024

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin
Copy link
Contributor

wangxin commented Oct 9, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin
Copy link
Contributor

wangxin commented Oct 21, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Contributor

PR test retriggered.

@liat-grozovik
Copy link
Collaborator

/azpw Azure.sonic-buildimage

@bingwang-ms
Copy link
Contributor

/azp run Azure.sonic-buildimage

@liushilongbuaa
Copy link
Contributor

PR validation will not pass. Please bypass policy force merge.

@dprital
Copy link
Collaborator

dprital commented Nov 22, 2024

PR validation will not pass. Please bypass policy force merge.

@liushilongbuaa , Do we need to do something here ? or the maintainer can handle it ?

@liushilongbuaa
Copy link
Contributor

PR validation will not pass. Please bypass policy force merge.

@liushilongbuaa , Do we need to do something here ? or the maintainer can handle it ?

Maintainer can handle it.
The PR Validation failure is false alert.

@dprital
Copy link
Collaborator

dprital commented Nov 24, 2024

@bingwang-ms , based on the comment above, can you please merge ?

@dprital
Copy link
Collaborator

dprital commented Nov 25, 2024

@bingwang-ms , Can you please merge and also cherry pick to 202405 ?

@dprital
Copy link
Collaborator

dprital commented Nov 28, 2024

@bingwang-ms , Can you please merge ?

@liat-grozovik
Copy link
Collaborator

@skr31 please check failures. we need this to get into 202405

@DavidZagury
Copy link
Contributor

@skr31 please check failures. we need this to get into 202405

@liat-grozovik there are no failure for @skr31 to check.
The only failed checker is Test kvmtest-t1-lag by Elastictest which is not running when retriggering the checkers.
And, as @liushilongbuaa said

@bingwang-ms , this PR only change files in platform/mellanox. PR validation will not run kvmtest because vs image didn't changed.

So we can't rerun this checker and no matter what we do/did in the last 3 months - this checker will stay failed and it is a false alert.

@skr31 skr31 force-pushed the fix_version_component_caching branch from 21360b4 to 2222f7e Compare December 5, 2024 13:29
@liat-grozovik liat-grozovik merged commit d53d86d into sonic-net:master Dec 9, 2024
12 checks passed
@dprital
Copy link
Collaborator

dprital commented Dec 9, 2024

@bingwang-ms , Can you please cherry pick to 202405 ?

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 9, 2024
- Why I did it
The component versions file that is created during compilation was not being updated because it was being cached, even when some of the versions on it should have been updated.

- How I did it
Removed component-versions.dep
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #21094

mssonicbld pushed a commit that referenced this pull request Dec 9, 2024
- Why I did it
The component versions file that is created during compilation was not being updated because it was being cached, even when some of the versions on it should have been updated.

- How I did it
Removed component-versions.dep
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #21410

VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
- Why I did it
The component versions file that is created during compilation was not being updated because it was being cached, even when some of the versions on it should have been updated.

- How I did it
Removed component-versions.dep
ayurkiv-nvda pushed a commit to ayurkiv-nvda/sonic-buildimage that referenced this pull request Jan 22, 2025
tshalvi pushed a commit to tshalvi/sonic-buildimage that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants