[Mellanox] Fixed sai xml name format bug #19967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skr31
force-pushed
the
fix_cmis_sai_xml_format
branch
from
20f56dc to
5e9fa77
Compare
dprital
approved these changes
Aug 21, 2024
DavidZagury
approved these changes
Aug 21, 2024
liat-grozovik
approved these changes
Aug 21, 2024
matiAlfaro
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Aug 21, 2024
- Why I did it Fixed the name that the script looks for when checking sai_*.xml - How I did it Instead of searching with a general regex, the name of sai*.xml is taken from a variable in sai.profile.
|
@prgeor FYI |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Aug 22, 2024
- Why I did it Fixed the name that the script looks for when checking sai_*.xml - How I did it Instead of searching with a general regex, the name of sai*.xml is taken from a variable in sai.profile.
|
Cherry-pick PR to 202405: #19983 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 24, 2024
- Why I did it Fixed the name that the script looks for when checking sai_*.xml - How I did it Instead of searching with a general regex, the name of sai*.xml is taken from a variable in sai.profile.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
vvolam
pushed a commit
to vvolam/sonic-buildimage
that referenced
this pull request
Sep 12, 2024
- Why I did it Fixed the name that the script looks for when checking sai_*.xml - How I did it Instead of searching with a general regex, the name of sai*.xml is taken from a variable in sai.profile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixed the name that the script looks for when checking sai_*.xml
Work item tracking
How I did it
Instead of searching with a general regex, the name of sai*.xml is taken from a variable in sai.profile.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)